From 31c0152664d94420789a65a161ba58bdccb2e194 Mon Sep 17 00:00:00 2001 From: satoru Date: Sun, 9 Jul 2023 05:09:12 +0800 Subject: [PATCH] chore: Preallocate space for slices with known size (#575) Signed-off-by: satoru Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> --- pkg/registry/endpoints.go | 2 +- pkg/tag/tag.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/registry/endpoints.go b/pkg/registry/endpoints.go index a04ff3b2..3d018112 100644 --- a/pkg/registry/endpoints.go +++ b/pkg/registry/endpoints.go @@ -247,9 +247,9 @@ func SetRegistryEndpointCredentials(prefix, credentials string) error { // ConfiguredEndpoints returns a list of prefixes that are configured func ConfiguredEndpoints() []string { - r := []string{} registryLock.RLock() defer registryLock.RUnlock() + r := make([]string, 0, len(registries)) for _, v := range registries { r = append(r, v.RegistryPrefix) } diff --git a/pkg/tag/tag.go b/pkg/tag/tag.go index 36d083d3..121757e8 100644 --- a/pkg/tag/tag.go +++ b/pkg/tag/tag.go @@ -124,7 +124,7 @@ func (il ImageTagList) Add(tag *ImageTag) { // SortByName returns an array of ImageTag objects, sorted by the tag's name func (il ImageTagList) SortAlphabetically() SortableImageTagList { - sil := SortableImageTagList{} + sil := make(SortableImageTagList, 0, len(il.items)) for _, v := range il.items { sil = append(sil, v) } @@ -136,7 +136,7 @@ func (il ImageTagList) SortAlphabetically() SortableImageTagList { // SortByDate returns a SortableImageTagList, sorted by the tag's date func (il ImageTagList) SortByDate() SortableImageTagList { - sil := SortableImageTagList{} + sil := make(SortableImageTagList, 0, len(il.items)) for _, v := range il.items { sil = append(sil, v) }