fix flaky tests #2550
Merged
fix flaky tests #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseduffield
force-pushed
the
handle-flakey-tests
branch
from
e99ae53 to
c095dbe
Compare
jesseduffield
commented
Apr 14, 2023
| ). | ||
| // Add both files to the patch; the first will conflict, the second won't | ||
| PressPrimaryAction(). | ||
| Tap(func() { |
Owner
Author
There was a problem hiding this comment.
I'm adding an assertion between pressing space and selecting the next item so that the test isn't going too fast for the code to keep up. The code should prevent an insanely fast user from tripping up the code, but at the moment it is failing to do that.
jesseduffield
force-pushed
the
handle-flakey-tests
branch
from
c095dbe to
7f5465a
Compare
Contributor
Uffizzi Ephemeral Environment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me attempting to fix a couple flaky tests
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary