Smart insert #29

Merged
merged 1 commit into from Apr 14, 2012

Conversation

Projects
None yet
3 participants
@Xeago

Xeago commented Mar 21, 2012

Add insert functionality in a different way than @rgraciano. Instead of by default selecting all text and copying that into the editor, copy what currently is selected based on user preference and continue as normal.

I added a checkbox in the preference menu, and accidentally deleted the menubar (for which I saw no reason to exist tho..).
This approach has less of an impact to the overall structure of the code than @rgraciano's approach and might thus be easier to support. This is as requested in Issue 8, comment from @subtleGradient.

Twan Wolthof
Add a checkbox for SmartEdit => Insert if no text is currently select…
…ed, instead of the default select-all behavior.

Add an if for SmartEdit.
@GreyBurkart

This comment has been minimized.

Show comment
Hide comment
@GreyBurkart

GreyBurkart Mar 22, 2012

Collaborator

Thanks, will be taking a look soon!

Collaborator

GreyBurkart commented Mar 22, 2012

Thanks, will be taking a look soon!

0hoo added a commit that referenced this pull request Apr 14, 2012

Merge pull request #29 from Xeago/master
Smart insert - from Xeago

@0hoo 0hoo merged commit 729ad6e into jessegrosjean:master Apr 14, 2012

@GreyBurkart

This comment has been minimized.

Show comment
Hide comment
@GreyBurkart

GreyBurkart Apr 14, 2012

Collaborator

@Xeago Nifty bit of work, thanks for letting us know! We tweaked the implementation a bit to make toggling the option require fewer clicks and so on, so check it out and let us know what you think! Thank you again.

Collaborator

GreyBurkart commented Apr 14, 2012

@Xeago Nifty bit of work, thanks for letting us know! We tweaked the implementation a bit to make toggling the option require fewer clicks and so on, so check it out and let us know what you think! Thank you again.

@Xeago

This comment has been minimized.

Show comment
Hide comment
@Xeago

Xeago Apr 14, 2012

Thanks for merging, it looks and feels better this way! Please consider closing @rgraciano's pull request, this achieves the same: insert only.

Xeago commented Apr 14, 2012

Thanks for merging, it looks and feels better this way! Please consider closing @rgraciano's pull request, this achieves the same: insert only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment