This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
Simplify tableEditingController APIs #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.54% (diff: 100%)@@ develop #84 diff @@
==========================================
Files 10 10
Lines 391 387 -4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 366 362 -4
Misses 25 25
Partials 0 0
|
psartzetakis
approved these changes
Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing #83, I realized we can simplify
TableEditingControllermore.I think @psartzetakis was following the existing patterns:
In the case of
TableEditingController, there is no protocol. We just need to pass in these 2 closures.So, we can remove these internal functions and just call the closure properties directly.