Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuron View Inconsistency #32

Closed
mojivalipour opened this issue Jan 12, 2020 · 4 comments
Closed

Neuron View Inconsistency #32

mojivalipour opened this issue Jan 12, 2020 · 4 comments

Comments

@mojivalipour
Copy link

As you can see in the following example, the neuron view output is different than what you've provided in the readme of this repo. Please also check this one.

The current output:
image

The demanded output:
image

@jessevig
Copy link
Owner

jessevig commented Jan 12, 2020

Okay, I see. You actually need to click the plus sign that comes up when you hover over the tokens on the left. I'll make that more clear in the README.

@mojivalipour
Copy link
Author

Cool, this is a nice feature, but why you don't integrate all of these things into one? It's really a useful library for attention models, but there are some integration and documentation problems in the current version, which make it unsuitable for mass usage.

@jessevig
Copy link
Owner

jessevig commented Jan 12, 2020

Thanks. I'm working on expanding the documentation.Do you have a specific suggestion for a different integration? The reason for the difference between the neuron view and the other views is that the neuron view needs access to the queries and keys, which are not available in the current version of transformers. I don't want to have the head view and model view rely on the forked version of transformers because this creates a dependency that needs to be updated with each new release of transformer models. The head view and model view are the more commonly used views.

@mojivalipour
Copy link
Author

Yes, I see why you did this, but I think HuggingFace (@huggingface) are friendly if you raise an issue and inform them about your technology. I think it is good for them to use and integrate your repo into theirs. Their repo, which is based on Transformers, suffered from the lack of this kind of visualization support. This solution is the best idea if they (@clmnt, @julien-c, @LysandreJik, @n1t0, @Pierrci, @thomwolf, and @VictorSanh) cooperate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants