Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add codecov integration #576

Merged
merged 9 commits into from May 12, 2020
Merged

chore: add codecov integration #576

merged 9 commits into from May 12, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 12, 2020 •
edited

Let's see what happens. I can delete some tests as a check for that behavior.

Closes #69

@codecov
Copy link

codecov bot commented May 12, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@f6e0bd0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #576   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        44           
  Lines             ?      1367           
  Branches          ?       560           
==========================================
  Hits              ?      1367           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e0bd0...4df3ea1. Read the comment docs.

G-Rath
G-Rath approved these changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good. We've got this now.

@SimenB
Copy link
Member Author

SimenB commented May 12, 2020

Hmm, not sure how to get it into the status checks

@G-Rath
Copy link
Collaborator

G-Rath commented May 12, 2020

What you remove some tests so that the coverage changes?

@SimenB
Copy link
Member Author

SimenB commented May 12, 2020

@G-Rath seems to work? 🙂

@G-Rath
Copy link
Collaborator

G-Rath commented May 12, 2020

Nice! thats useful <3

@SimenB
Copy link
Member Author

SimenB commented May 12, 2020

It's not updating the comment, so I assume disabling it worked

@SimenB SimenB changed the title chore: add codecov action chore: add codecov integration May 12, 2020
@SimenB SimenB merged commit feac055 into master May 12, 2020
@SimenB SimenB deleted the codecov branch May 12, 2020 08:07
@github-actions
Copy link

🎉 This PR is included in version 23.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Considering adding codecov integration
2 participants
@SimenB @G-Rath