Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lowercase-name): support .each methods #746

Merged
merged 1 commit into from Feb 16, 2021
Merged

fix(lowercase-name): support .each methods #746

merged 1 commit into from Feb 16, 2021

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jan 21, 2021

Fixes #744

I've taken the "throw code in the air and see where it settles after a few iterations" refactor method.

I think we could probably extract a helper for checking if a things an .each, but not going to try to build it until we've got more rules interacting with .each.

Will conflict with #745, so should be rebased before merging.

@G-Rath G-Rath requested a review from SimenB Jan 21, 2021
@G-Rath G-Rath merged commit 3d847b2 into master Feb 16, 2021
22 checks passed
@G-Rath G-Rath deleted the fix-lowercase-name branch Feb 16, 2021
github-actions bot pushed a commit that referenced this issue Feb 16, 2021
## [24.1.4](v24.1.3...v24.1.4) (2021-02-16)

### Bug Fixes

* **lowercase-name:** support `.each` methods ([#746](#746)) ([3d847b2](3d847b2))
* **require-top-level-describe:** handle `describe.each` properly ([#745](#745)) ([677be45](677be45))
@github-actions
Copy link

@github-actions github-actions bot commented Feb 16, 2021

🎉 This PR is included in version 24.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant