Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' matchers. #229

Open
wants to merge 5 commits into
base: master
from

Conversation

@hansal7014
Copy link

hansal7014 commented Sep 11, 2019

What changes are being made? (feature/bug)

Adding 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' date matchers.

Why are these changes necessary? Link any related issues

New date matchers are being added as requested in issue #117

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant
hansal7014 added 5 commits Sep 10, 2019
Adding 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' type definitions to index.d.ts
Adding documentation for 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' matchers.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #229   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         109    115    +6     
  Lines         554    584   +30     
  Branches       97    101    +4     
=====================================
+ Hits          554    584   +30
Impacted Files Coverage Δ
src/matchers/toBeBetween/predicate.js 100% <100%> (ø)
src/matchers/toBeBeforeOrEqualTo/index.js 100% <100%> (ø)
src/matchers/toBeBeforeOrEqualTo/predicate.js 100% <100%> (ø)
src/matchers/toBeBetween/index.js 100% <100%> (ø)
src/matchers/toBeAfterOrEqualTo/predicate.js 100% <100%> (ø)
src/matchers/toBeAfterOrEqualTo/index.js 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1329f78...a7446e0. Read the comment docs.

@hansal7014

This comment has been minimized.

Copy link
Author

hansal7014 commented Oct 1, 2019

Hi @mattphillips,
Could you please review my pull work and merge it or provide feedback as needed.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.