Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ESLint6 #77

merged 5 commits into from Oct 10, 2019


Copy link

commented Sep 21, 2019

This PR combines #70 and #76, then continues by resolving additional test failures and configuring Travis testing matrix across ESLint versions.


  • (from #70) expand ESLint deps ^5.6.0 ▶️ ^4.0.0 || ^5.0.0 || ^6.0.0
  • (from #70 & #76) update defaults for parserOptions & rules (to satisfy type definitions described in #76)
  • (from #76) update
  • integrationTests/custom-parser.test.js > Doesn't override parser when not set receives different text for the same result from ESLint6. Change the test to expect the result according to the version being used†.
  • config travis to run a node * eslint version matrix, skipping the combination node@6 + eslint@6
  • update the jest logo url in
  • [CNR] try to reproduce the problem reported in issue #75

† This was done with two special techniques: 1) checking eslint.CLIEngine.version, 2) adding a snapshot for both versions and "skipping" the version not being tested. Both techniques have multiple alternate solutions. ex. 1) could be made to import the package.json file and check version there. 2) could be converted to inline snapshots. Open to alternate solutions if the current ones aren't palatable.

Closes #70

@wheeler wheeler changed the title [WIP] Allow ESLint6 Allow ESLint6 Sep 22, 2019
@wheeler wheeler marked this pull request as ready for review Sep 22, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

poke @ljharb - any thoughts on this more complete ESLint6 PR?

ljharb approved these changes Oct 7, 2019
Copy link

left a comment

seems reasonable to me

@ljharb ljharb requested review from SimenB and rogeliog Oct 7, 2019
SimenB approved these changes Oct 10, 2019
Copy link

left a comment

this is great!

@SimenB SimenB merged commit 850f80c into jest-community:master Oct 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

@wheeler wheeler deleted the wheeler:mw-eslint6 branch Oct 10, 2019
@SimenB SimenB referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.