-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate other test runners next to Jasmine #3155
Comments
Nice! @derekstavis |
This should be easier now that #3668 is merged |
@rogeliog wanna try making an ava runner for Jest? :) |
I'll give it a try! |
I've been working with Python and Perl test runners based on your example with pyjest-runner, @cpojer . One of the issues I have run into is what to do when the test matching parameter precludes all tests for a particular project. Not all runners that one would want to interface with will report skipped tests, so knowing how many exist and how many are skipped may not be possible. Thus we would get the Haven't seen anyone discuss this yet. |
@dyst5422 thanks for weighing in. You should only be getting this error message if the results object doesn't contain a single "test". If you are skipping tests, you should return the list of tests or a dummy list of tests so you don't get that error message. However, you are right this error message should possibly be moved into @rogeliog made runners for mocha and ava (jest-runner-mocha, jest-runner-ava), so I'm closing this task as most of what's written above was implemented. |
@cpojer Yes, this case where ALL tests are skipped is the one I'm interested in. For now, I can put in a dummy list of tests (I mean really I'm not overly offended by the test failure when it notes that it was because of no tests, so I might skip actually going that). I do think that this error message might better belong in the |
The reason this exists is that we had product developers put product code into test files, so we added this error to prevent people from doing it. I think for now the dummy result makes sense. |
I have no idea how it would come about that they would put product code into the test files, but I'm probably just not being imaginative enough. In any case, the dummy result is fine if this error is serving other needs. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Jest is completely test runner agnostic. For example, Jest can wrap other test runners entirely and for a while we shipped with both jasmine1 and jasmine2. However, we have never capitalized on the difference between Jest "the test-framework runner" and the test runner (currently Jasmine) itself.
TODO:
jest-jasmine2
andrunTest.js
/TestRunner.js
. Currently the API isjestJasmine2(…).then(results => …)
. The result currently looks like this: https://github.com/cpojer/jest/blob/master/types/TestResult.js#L126 which comes from Jasmine. We should rename these things to make more sense and normalize the results we get from Jasmine.jest-jasmine2
generic so that the setup-pieces can be shared across test runner adapters.cc @MarcoWorms
The text was updated successfully, but these errors were encountered: