Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): add type definitions for asymmetric closeTo matcher #12304

merged 2 commits into from Feb 6, 2022


Copy link


#12243 landed with new asymmetric closeTo matcher, but seems like type definitions went missing. Easy to fix (;

Test plan

Type tests included.

Copy link

Codecov Report

Merging #12304 (0fb15f3) into main (5f63582) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12304      +/-   ##
- Coverage   67.29%   67.25%   -0.05%     
  Files         329      329              
  Lines       17336    17346      +10     
  Branches     5074     5074              
- Hits        11667    11666       -1     
- Misses       5637     5648      +11     
  Partials       32       32              
Impacted Files Coverage Δ
packages/jest-types/__typetests__/expect.test.ts 0.00% <0.00%> (ø)
packages/expect/src/utils.ts 96.09% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f63582...0fb15f3. Read the comment docs.

Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks for keeping an eye out!

@SimenB SimenB merged commit 94a6752 into jestjs:main Feb 6, 2022
Copy link

Biki-das commented Feb 6, 2022

thanks @mrazauskas.

Copy link

github-actions bot commented Mar 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants