Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@jest/test-result, @jest/types)!: replace Bytes and Milliseconds types with number #13155

merged 3 commits into from Aug 20, 2022


Copy link

@mrazauskas mrazauskas commented Aug 20, 2022

Related #12406


Seems like number is enough instead of Bytes and Milliseconds types. Just like Path type was replaced with string some time ago.

Test plan

Type definitions should build without an error.

Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish typescript had nominal types ☹️

@SimenB SimenB merged commit 3bef02e into jestjs:main Aug 20, 2022
@mrazauskas mrazauskas deleted the feat-remove-Milliseconds-type branch August 20, 2022 11:51
Copy link

SimenB commented Aug 25, 2022

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants