Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-snapshot): pass snapshotFormat through when diffing failing snapshots #13181

merged 7 commits into from Aug 26, 2022


Copy link

@SimenB SimenB commented Aug 26, 2022


Fixes #13180

Test plan

Test added

@SimenB SimenB merged commit 9492a56 into jestjs:main Aug 26, 2022
@SimenB SimenB deleted the pass-format-options-diffing-snapshot branch August 26, 2022 13:28
@@ -303,7 +304,7 @@ export const printSnapshotAndReceived = (

// Fall through to fix a regression for custom serializers
// like jest-snapshot-serializer-raw that ignore the indent option.
const b0 = serialize(received, 0);
const b0 = serialize(received, 0, snapshotFormat);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

[Bug]: Cannot show diff when .toMatchInlineSnapshot throws exception
2 participants