Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty-print React elements #1566

merged 3 commits into from
Sep 1, 2016

Pretty-print React elements #1566

merged 3 commits into from
Sep 1, 2016


Copy link

@gaearon gaearon commented Sep 1, 2016

Fixes #1429.
Fixes #1509.

Adds pretty-printing of elements both to regular tests (yay shallow rendering diffs!) and to snapshot tests (which had pretty-printing for instances but not for elements).

screen shot 2016-09-01 at 16 31 54

screen shot 2016-09-01 at 16 33 59

@ghost ghost added the CLA Signed ✔️ label Sep 1, 2016
Copy link

cpojer commented Sep 1, 2016

Awesome! I just updated some minor require odering nit.

Copy link

Current coverage is 90.37% (diff: 100%)

Merging #1566 into master will increase coverage by 0.10%

@@             master      #1566   diff @@
  Files            28         28          
  Lines          1121       1133    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
+ Hits           1012       1024    +12   
  Misses          109        109          
  Partials          0          0          

Powered by Codecov. Last update d45f813...221d409

@cpojer cpojer merged commit 5a72b1d into master Sep 1, 2016
@gaearon gaearon deleted the jsx branch September 1, 2016 16:20
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

Circular References in React Native Snapshots should not contain internal React instances
3 participants