Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the list of methods to go to spyOn accessType for Jest Object API doc #5404

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Add link to the list of methods to go to spyOn accessType for Jest Object API doc #5404

merged 1 commit into from
Jan 27, 2018

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Jan 27, 2018

Summary

Currently the API Doc doesn't have the link to go to jest.spyOn(object, methodName, accessType?). This PR makes the developers easy to navigate to jest.spyOn(object, methodName, accessType?) method description by clicking the link on the list of methods on the top of the API doc page.

Test plan

  • Run yarn start in the website directory.
  • Browse to http://localhost:3000/jest/docs/en/jest-object.html using any browsers
  • Check if the list of methods contain jest.spyOn(object, methodName, accessType?)
  • Click on the link jest.spyOn(object, methodName, accessType?) and see if it navigates correctly to the usage description of the method

@codecov-io
Copy link

Codecov Report

Merging #5404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5404   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files         205      205           
  Lines        6925     6925           
  Branches        4        3    -1     
=======================================
  Hits         4247     4247           
  Misses       2677     2677           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7c3b1...ddaa872. Read the comment docs.

@SimenB SimenB merged commit 922b037 into jestjs:master Jan 27, 2018
@ahnpnl ahnpnl deleted the fix/add-title-spyOn-accessType-forAPIDoc branch January 27, 2018 13:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants