Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add worker build on CI #7637

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add worker build on CI #7637

wants to merge 2 commits into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 16, 2019

Summary

From #7610. @rickhanlonii could you take a look? 🙂

Test plan

Will fail (for now)

@SimenB
Copy link
Member Author

SimenB commented Jan 22, 2019

worker_threads is unflagged in node 11.7.0, so the extra job isn't necessary. When (if) we land #7681 I'll update this PR to remove all the disableWorkerThreads: true and see where we're at

@SimenB SimenB force-pushed the ci-worker branch 2 times, most recently from 7aa7645 to 271e493 Compare January 29, 2019 18:15
@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

Circle has node 11.8 now, which has the umask fix. Rebased, hopefully a better result this time 🙂

@thymikee
Copy link
Collaborator

We test threads but we're actually running our test suite serially. Maybe it's worth to run tests by default on 2 or 4 workers and run in band e.g. on travis or somewhere?

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

I wanna see that tests pass without being stupidly slow first. If they do, then we can test by actually spinning up workers 🙂

These have to be fixed first:
image

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

haha, it just died 😛 But looking at, and fixing, multiProjectRunner might be what we're missing. If anybody wants to pick it up

@SimenB
Copy link
Member Author

SimenB commented Aug 22, 2019

Test failures on node 12, that's odd...

@SimenB
Copy link
Member Author

SimenB commented Nov 10, 2019

whatever that old issue was, it seems to have been fixed 👍

image

Will need to look into why coverage fails, but this is super promising

@SimenB
Copy link
Member Author

SimenB commented Apr 27, 2020

Very interesting - tests fail on circus, but passes on GH Actions. The failing test on CI passes on my local machine. Very odd...

@SimenB SimenB modified the milestones: Jest 26, High priority future May 2, 2020
'jest-silent-reporter',
{showPaths: true, showWarnings: true, useDots: true},
],
'default',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, soz. At the time it was useful to get test timings and such, now that we're down to actual test failures it should be good to move back 😉

@sibelius
Copy link

sibelius commented Jun 8, 2020

for those that want to test this, check this patch-package https://gist.github.com/sibelius/c6ef3f0890814dd4163a9ada0cd739f1

@SimenB
Copy link
Member Author

SimenB commented Jun 8, 2020

@sibelius very interested in hearing numbers if you play with - does it impact memory/cpu usage?

@sibelius
Copy link

sibelius commented Jun 8, 2020

I've tried to use worker_threads because child process was failing for us, here is the issue #10144

When using worker_threads we got some

CircleCI received exit code 137 

137 means Out of Memory.

So worker threads is kind of worse than child process right now for us

mongodb-memory-server was causing OOM for us because it was spinning 1 mongod per test file, we fixed this here shelfio/jest-mongodb#209

but worker_threads still leaking on CircleCI

but it does not leak when running local, --logHeapUsage show always less than 300mb, so not sure if leakage is because of node 12.18.0 or because of docker or circleci specific

@sibelius
Copy link

sibelius commented Jun 9, 2020

we fixed most issues of our tests

and now worker_threads is working fine for us (node 12.18.0)

we didn't notice any improvement in cpu time or memory usage

@jeysal
Copy link
Contributor

jeysal commented Jun 14, 2020

https://www.npmjs.com/package/piscina just leaving this here as something to maybe explore in the future, who knows, maybe it's faster than jest-workers worker threads farm impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants