diff --git a/.circleci/config.yml b/.circleci/config.yml index 7b056fa95d55..71b2b7642ddd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -21,7 +21,7 @@ jobs: lint-and-typecheck: working_directory: ~/jest docker: - - image: circleci/node:10 + - image: circleci/node:12 steps: - checkout - restore-cache: *restore-cache diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c05952b8b330..cc3f55ca834d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -42,7 +42,7 @@ _Before_ submitting a pull request, please make sure the following is doneā€¦ python --version ``` -1. Make sure you have a compatible version of `node` installed (As of July 10th 2019, `v10.x` is recommended since there is a known issue with `v12.x` [#8490](https://github.com/facebook/jest/issues/8490)). +1. Make sure you have a compatible version of `node` installed (As of October 25th 2019, `v12.x` is recommended). ```sh node -v diff --git a/packages/jest-worker/src/workers/NodeThreadsWorker.ts b/packages/jest-worker/src/workers/NodeThreadsWorker.ts index f33181f9f874..4e300884eef9 100644 --- a/packages/jest-worker/src/workers/NodeThreadsWorker.ts +++ b/packages/jest-worker/src/workers/NodeThreadsWorker.ts @@ -7,8 +7,6 @@ import * as path from 'path'; import {PassThrough} from 'stream'; -// ESLint doesn't know about this experimental module -// eslint-disable-next-line import/no-unresolved import {Worker} from 'worker_threads'; import mergeStream = require('merge-stream'); diff --git a/packages/jest-worker/src/workers/threadChild.ts b/packages/jest-worker/src/workers/threadChild.ts index bab076dce2c1..fc9105ce99ce 100644 --- a/packages/jest-worker/src/workers/threadChild.ts +++ b/packages/jest-worker/src/workers/threadChild.ts @@ -5,8 +5,6 @@ * LICENSE file in the root directory of this source tree. */ -// ESLint doesn't know about this experimental module -// eslint-disable-next-line import/no-unresolved import {isMainThread, parentPort} from 'worker_threads'; import {