Corresponded SubExpr Visitor #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
commented
Jan 17, 2020
| if (accepted != null) return accepted; | ||
| } | ||
| // Case trees and clauses? They are unlikely to be isomorphic. | ||
| return null; |
| ClassCallExpression coreClassExpr = coreExpr.cast(ClassCallExpression.class); | ||
| if (coreClassExpr == null) return null; | ||
| // How about the other subexpressions? | ||
| return expr.getBaseClassExpression().accept(this, coreClassExpr.getExpr()); |
There was a problem hiding this comment.
\eval is one of the places where you cannot match expressions. We will discuss what to do in these cases later.
src/main/java/org/arend/typechecking/visitor/CorrespondedSubExprVisitor.java
Outdated
Show resolved
Hide resolved
ice1000
force-pushed
the
subexpr
branch
2 times, most recently
from
71746cb
to
8eb780c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP