Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corresponded SubExpr Visitor #110

Merged
merged 22 commits into from Feb 4, 2020
Merged

Corresponded SubExpr Visitor #110

merged 22 commits into from Feb 4, 2020

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jan 16, 2020

WIP

@ice1000 ice1000 requested a review from valis Jan 16, 2020
@ice1000 ice1000 self-assigned this Jan 16, 2020
Copy link
Contributor Author

@ice1000 ice1000 left a comment

Some questions @valis

if (accepted != null) return accepted;
}
// Case trees and clauses? They are unlikely to be isomorphic.
return null;
Copy link
Contributor Author

@ice1000 ice1000 Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to do?

ClassCallExpression coreClassExpr = coreExpr.cast(ClassCallExpression.class);
if (coreClassExpr == null) return null;
// How about the other subexpressions?
return expr.getBaseClassExpression().accept(this, coreClassExpr.getExpr());
Copy link
Contributor Author

@ice1000 ice1000 Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do?

Copy link
Collaborator

@valis valis Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\eval is one of the places where you cannot match expressions. We will discuss what to do in these cases later.

@ice1000 ice1000 force-pushed the subexpr branch 2 times, most recently from 71746cb to 8eb780c Compare Jan 24, 2020
@ice1000 ice1000 marked this pull request as ready for review Jan 25, 2020
@valis valis merged commit 0c7533f into master Feb 4, 2020
@ice1000 ice1000 added this to the 1.3 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants