Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the whole project #177

Merged
merged 10 commits into from Mar 12, 2020
Merged

Reorganize the whole project #177

merged 10 commits into from Mar 12, 2020

Conversation

@ice1000
Copy link
Collaborator

ice1000 commented Mar 12, 2020

Summary

  • Created these modules:
    • parser, generated ANTLR parser (the generation is still done in buildSrc)
    • proto, generated protobufs (so other subprojects don't need to touch the protobuf gradle plugin)
    • api, the ext package
    • cli, the frontend package, depends on base, parser, api, proto
      • the Prelude.arc generation task is renamed to buildPrelude and is moved to this subproject, and the generated dir is now lib/Prelude.arc
      • The prelude task is renamed to copyPrelude -- it copies the lib directory to the build classes directory of the cli subproject, so it's still in the -full jar
    • base, previously main, all the other stuffs, depends on api, proto
  • The tests are kept in the root project, and it depends on cli

Comments

  • git blame still shows the original author of the moved files :trollface:

Review guide

It's recommended to open this link to avoid reviewing trivial changes (Java & proto files are filtered out).

Resolves #169

@ice1000 ice1000 requested a review from valis Mar 12, 2020
@ice1000 ice1000 self-assigned this Mar 12, 2020
ice1000 added 9 commits Mar 12, 2020
@valis
valis approved these changes Mar 12, 2020
@ice1000 ice1000 merged commit 687dffb into master Mar 12, 2020
6 checks passed
6 checks passed
gradle (ubuntu-latest, 1.8)
Details
gradle (ubuntu-latest, 11)
Details
gradle (macos-latest, 1.8)
Details
gradle (macos-latest, 11)
Details
gradle (windows-latest, 1.8)
Details
gradle (windows-latest, 11)
Details
@ice1000 ice1000 deleted the m branch Mar 12, 2020
@ice1000 ice1000 added this to the 1.3 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.