Address #135 #137
Merged
Address #135 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getingIntention`
|
This should be merged after #134 because it's based on it. |
ice1000
reviewed
Mar 1, 2020
| abstract fun isApplicableTo(element: T, caretOffset: Int, editor: Editor?): Boolean | ||
| abstract fun isApplicableTo(element: T, caretOffset: Int, editor: Editor): Boolean | ||
|
|
||
| abstract fun applyTo(element: T, project: Project?, editor: Editor?) | ||
| abstract fun applyTo(element: T, project: Project, editor: Editor) |
There was a problem hiding this comment.
I made these not-null because these arguments are never null when these methods are invoked.
By doing this, some null-checks are removed for free.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #135. Screenshot will be added later