[aisdk] Pass correct CallID and args on computer use tool call #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loreto
approved these changes
Nov 10, 2025
| "action": { | ||
| "type": "screenshot" | ||
| }, | ||
| "pending_safety_checks": [] |
Contributor
There was a problem hiding this comment.
Would it be better to omit this field and test it all works even with the field omitted?
| "command": "ls -la", | ||
| "working_directory": "/tmp" | ||
| "call_id": "call_123", | ||
| "action": { |
Contributor
There was a problem hiding this comment.
If we are really polishing the computer call use case, it could be good to add test cases for all the possible actions open ai returns.
And maybe another test for pending safety checks (omitted, empty, and filled)
Contributor
Author
There was a problem hiding this comment.
I'll do that in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?
Unit test; running testpitot locally
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 License.
By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 License as stated in the Community Contribution License.