From 1bdaf45f77895289c762e2ea57ee44a8ab981149 Mon Sep 17 00:00:00 2001 From: Adam Shiervani Date: Thu, 16 Oct 2025 15:28:16 +0200 Subject: [PATCH 1/3] chore: add PR templates (feature, bug fix) with issue linking and concise checklist --- .github/PULL_REQUEST_TEMPLATE/bugfix.md | 9 +++++++++ .github/PULL_REQUEST_TEMPLATE/feature.md | 18 ++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/bugfix.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/feature.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bugfix.md b/.github/PULL_REQUEST_TEMPLATE/bugfix.md new file mode 100644 index 000000000..074f5bd9d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/bugfix.md @@ -0,0 +1,9 @@ +Fixes # + +Summary of the fix +- What changed and why in 1–3 sentences. + +Checklist +- [ ] Linked to issue(s) above by issue number (e.g. `Closes #`) +- [ ] One problem per PR (no unrelated changes) +- [ ] Lints pass; CI green diff --git a/.github/PULL_REQUEST_TEMPLATE/feature.md b/.github/PULL_REQUEST_TEMPLATE/feature.md new file mode 100644 index 000000000..4e5f59af0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/feature.md @@ -0,0 +1,18 @@ +Closes # + +Summary + +- What and why in 1–3 sentences. + +Screenshots/videos (UI changes) + +- Add before/after images or a short clip. + +Checklist + +- [ ] Linked to issue(s) above by issue number (e.g. `Closes #`) +- [ ] One problem per PR (no unrelated changes) +- [ ] Lints pass; CI green +- [ ] Tricky parts are commented in code +- [ ] Internationalization (see `DEVELOPMENT.md` for details) +- [ ] Backward compatible with existing device firmware (See `DEVELOPMENT.md` for details) From e77a6c8f5b362911e7f47acf56080c3aa7b3b935 Mon Sep 17 00:00:00 2001 From: Adam Shiervani Date: Thu, 16 Oct 2025 15:44:24 +0200 Subject: [PATCH 2/3] chore: improve styling --- .github/PULL_REQUEST_TEMPLATE/bugfix.md | 4 ++-- .github/PULL_REQUEST_TEMPLATE/feature.md | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/bugfix.md b/.github/PULL_REQUEST_TEMPLATE/bugfix.md index 074f5bd9d..0a8025121 100644 --- a/.github/PULL_REQUEST_TEMPLATE/bugfix.md +++ b/.github/PULL_REQUEST_TEMPLATE/bugfix.md @@ -1,9 +1,9 @@ Fixes # -Summary of the fix +### Summary - What changed and why in 1–3 sentences. -Checklist +### Checklist - [ ] Linked to issue(s) above by issue number (e.g. `Closes #`) - [ ] One problem per PR (no unrelated changes) - [ ] Lints pass; CI green diff --git a/.github/PULL_REQUEST_TEMPLATE/feature.md b/.github/PULL_REQUEST_TEMPLATE/feature.md index 4e5f59af0..d5e0681a5 100644 --- a/.github/PULL_REQUEST_TEMPLATE/feature.md +++ b/.github/PULL_REQUEST_TEMPLATE/feature.md @@ -1,14 +1,14 @@ Closes # -Summary +### Summary - What and why in 1–3 sentences. -Screenshots/videos (UI changes) +### UI Changes - Add before/after images or a short clip. -Checklist +### Checklist - [ ] Linked to issue(s) above by issue number (e.g. `Closes #`) - [ ] One problem per PR (no unrelated changes) From 5c1aec496f0c0ae5afafd37eab7ffd52850461d4 Mon Sep 17 00:00:00 2001 From: Adam Shiervani Date: Thu, 16 Oct 2025 15:46:06 +0200 Subject: [PATCH 3/3] chore: remove internationalization checklist item from feature PR template. Save for later --- .github/PULL_REQUEST_TEMPLATE/feature.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/feature.md b/.github/PULL_REQUEST_TEMPLATE/feature.md index d5e0681a5..0db3f39e7 100644 --- a/.github/PULL_REQUEST_TEMPLATE/feature.md +++ b/.github/PULL_REQUEST_TEMPLATE/feature.md @@ -14,5 +14,4 @@ Closes # - [ ] One problem per PR (no unrelated changes) - [ ] Lints pass; CI green - [ ] Tricky parts are commented in code -- [ ] Internationalization (see `DEVELOPMENT.md` for details) - [ ] Backward compatible with existing device firmware (See `DEVELOPMENT.md` for details)