Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run coverage test? #3072

Closed
dr-shim opened this issue Jul 7, 2020 · 5 comments
Closed

How to run coverage test? #3072

dr-shim opened this issue Jul 7, 2020 · 5 comments
Labels
area/testing Issues relating to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@dr-shim
Copy link

dr-shim commented Jul 7, 2020

Is your feature request related to a problem? Please describe.
Nope.

Describe the solution you'd like
Please make a guide or update Makefile to include a coverage test.

Describe alternatives you've considered
Please make a guide or update Makefile to include a coverage test.

Additional context
Nope.

Environment details (if applicable):

  • Kubernetes version (e.g. v1.10.2): v1.14
  • Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): AWS eks
  • cert-manager version (e.g. v0.4.0): v0.15.2
  • Install method (e.g. helm or static manifests): helm

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 7, 2020
@wallrj
Copy link
Member

wallrj commented Aug 4, 2020

Hello @dr-shim

That's a great suggestion.
If you have time to contribute such a patch I'd be happy to test and review it.
Meanwhile you can get a limited report coverage using the standard go tools. E.g.

go test --coverprofile cover.out ./pkg/util/...
go tool cover  -html=cover.out

There is also some work by @munnerz to extract further coverage data from our E2E tests in #2236, but we still need modify our E2E test scripts to use those coverage enabled binaries and then to publish the coverage report somewhere.
If you'd like to help out with that, please join one of our standup meetings or community meetings to discuss.

/area testing
/priority backlog

@jetstack-bot jetstack-bot added area/testing Issues relating to testing priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 4, 2020
@jetstack-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@jetstack-bot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2021
@jetstack-bot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

@jetstack-bot
Copy link
Collaborator

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues relating to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants