Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 support? #608

Closed
jmreicha opened this issue Jun 1, 2018 · 12 comments
Closed

ARM64 support? #608

jmreicha opened this issue Jun 1, 2018 · 12 comments

Comments

@jmreicha
Copy link

@jmreicha jmreicha commented Jun 1, 2018

/kind feature

What you expected to happen:

It would be amazing if cert-manager had ARM support out of the box. This would make it easier to test out features that are running ARM based clusters.

@vielmetti
Copy link

@vielmetti vielmetti commented Jun 4, 2018

Just to be clear this is arm64 (64-bit) support and/or armhf (32-bit) support.

@jmreicha jmreicha changed the title ARM support? ARM64 support? Jun 4, 2018
@vielmetti
Copy link

@vielmetti vielmetti commented Jun 4, 2018

On an arm64 machine:

quay.io/jetstack/cert-manager-controller                 build               c9ec96235c
46        8 minutes ago       50.9 MB
quay.io/jetstack/cert-manager-acmesolver                 build               0697874742
63        9 minutes ago       11 MB

Builds work after a s/amd64/arm64/g in Dockerfile(s) and Makefile. I'm not yet set up to run any e2e tests or really any tests at all, but at least a little progress.

@retest-bot
Copy link

@retest-bot retest-bot commented Sep 2, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jmreicha
Copy link
Author

@jmreicha jmreicha commented Sep 5, 2018

/remove-lifecycle stale

@jmreicha
Copy link
Author

@jmreicha jmreicha commented Oct 30, 2018

@munnerz what would it look like to add arm64 support using bazel? Can you point me in the right direction?

@dendle
Copy link

@dendle dendle commented Nov 26, 2018

@vielmetti Hello Mr. Vielmetti, please could you elaborate a little on what you had to do to build cert-manager for ARM?

If I am following you, you ran sed s/amd64/arm64/g on some files in this repo. Could you tell me what files? I could not find any significant docker files to change in this repo - perhaps they are created as an output of the build process, but I have not been able to successfully run it yet.

Thanks for any help in advance.

On an arm64 machine:

quay.io/jetstack/cert-manager-controller                 build               c9ec96235c
46        8 minutes ago       50.9 MB
quay.io/jetstack/cert-manager-acmesolver                 build               0697874742
63        9 minutes ago       11 MB

Builds work after a s/amd64/arm64/g in Dockerfile(s) and Makefile. I'm not yet set up to run any e2e tests or really any tests at all, but at least a little progress.

@vielmetti
Copy link

@vielmetti vielmetti commented Dec 1, 2018

Hello @dendle - there are a couple of separate issues here -

Quay.io does not yet as far as i know support multi-architecture manifests, this seems to be the most public issue in that regard: moby/buildkit#409

Bazel for arm64 details are here: bazelbuild/bazel#5360 - there's been progress on this, but I don't see yet that Bazel has arm64 binaries.

@jmreicha
Copy link
Author

@jmreicha jmreicha commented Dec 3, 2018

I chatted with @munnerz in Slack, and he pointed a few things out which may be useful here.

The main issue that was brought up is that Prow is being used to build the project, which doesn't have arm64 builders so running the arm64 variant will need to be worked out somehow.

Here is the Prow configuration https://github.com/jetstack/testing/tree/master/config/jobs/cert-manager

@vielmetti
Copy link

@vielmetti vielmetti commented Dec 5, 2018

Just to be sure I have the same reference, is it this Prow?

https://github.com/kubernetes/test-infra/tree/master/prow

@jmreicha
Copy link
Author

@jmreicha jmreicha commented Dec 5, 2018

@vielmetti yep that's the one.

@munnerz munnerz self-assigned this Feb 7, 2019
@munnerz munnerz added this to the v0.7 milestone Feb 7, 2019
@munnerz munnerz added this to To do in v0.7 via automation Feb 7, 2019
@munnerz munnerz moved this from To do to Needs review in v0.7 Feb 8, 2019
v0.7 automation moved this from Needs review to Done Feb 13, 2019
@vielmetti
Copy link

@vielmetti vielmetti commented Feb 14, 2019

Thanks @munnerz for getting this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v0.7
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants