New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick-start guide for nginx ingress controller #1055

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
4 participants
@heckj
Collaborator

heckj commented Nov 7, 2018

This PR is a follow on to #378, picking up that branch to work on it and try to get a quick-start guide established since I'm digging through and learning the same pieces myself right now.

I'll need a few days to go through what's already here as well as rebasing over latest master, and want to align this with the more recent install work I think

@munnerz

This comment has been minimized.

Member

munnerz commented Nov 7, 2018

😅 looks like you got hit with probably the maximum number of GitHub/Prow automation emails possible! Sorry about all the messages!

Thanks for taking a stab at this, and please ping me if you run into any issues or have any questions!

@heckj

This comment has been minimized.

Collaborator

heckj commented Nov 7, 2018

@munnerz no worries - I've seen more on some the general k8s docs issues ;-) I'll start working it down once I've had a chance to read through and give this a once over.

@heckj heckj force-pushed the heckj:quickstart-guide branch from 005da03 to c1c257c Nov 7, 2018

@heckj heckj force-pushed the heckj:quickstart-guide branch from c1c257c to 6ca0de5 Nov 7, 2018

@heckj

This comment has been minimized.

Collaborator

heckj commented Nov 7, 2018

/release-note-none

@munnerz

This comment has been minimized.

Member

munnerz commented Nov 7, 2018

/ok-to-test

@heckj heckj force-pushed the heckj:quickstart-guide branch from 6caad25 to 25ee344 Nov 10, 2018

@heckj heckj force-pushed the heckj:quickstart-guide branch from ea07526 to 30c5f98 Nov 17, 2018

@heckj heckj force-pushed the heckj:quickstart-guide branch from 30c5f98 to cb38a35 Nov 17, 2018

@heckj

This comment has been minimized.

Collaborator

heckj commented Nov 19, 2018

@munnerz all updated!

At one point (I think in the slack/chat) you'd also mentioned maybe including some example command that would dump the secret and show the details of the certificate that was provided. I was looking around, and can do the decryption sort of manually, but don't have a spiffy one-liner to use to make that information easily visible in the quick-start. Do you happen to have such a thing? If so, I'll happily add it to the PR.

Otherwise, I've run through all these steps explicitly, including the final steps with updating the ingress annotation and deleting the secret, and it works beautifully - so I think this is ready to go. I'll remove the WIP from the title at this point.

Let me know if there's additional updates you'd like to see here!

@heckj heckj changed the title from WIP: Add quick-start guide for nginx ingress controller to Add quick-start guide for nginx ingress controller Nov 19, 2018

mt-inside and others added some commits Mar 2, 2018

Adding quick-start guide w/ nginx ingress controller
Signed-off-by: Joe Heck <heckj@mac.com>
remaining updates from feedback
Signed-off-by: Joe Heck <heckj@mac.com>

@heckj heckj force-pushed the heckj:quickstart-guide branch from 49404da to 71aaad9 Nov 19, 2018

Show resolved Hide resolved README.md Outdated
a few last updates missed earlier
Signed-off-by: Joe Heck <heckj@mac.com>
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
updating and fixing markdown links
Signed-off-by: Joe Heck <heckj@mac.com>
@heckj

This comment has been minimized.

Collaborator

heckj commented Nov 22, 2018

/test e2e v1.11

@heckj

This comment has been minimized.

Collaborator

heckj commented Nov 22, 2018

@munnerz FYI - while submitting this PR, I saw a lot of flake failures with e2e v1.11, and some with e2e v1.12. Enough to be significantly noticable.

@munnerz

This comment has been minimized.

Member

munnerz commented Nov 22, 2018

while submitting this PR, I saw a lot of flake failures with e2e v1.11, and some with e2e v1.12. Enough to be significantly noticable.

Yep I've noticed some test failures around the Vault issuer occasionally, as well as the occasional (although less frequent) failures in the ACME provider.

I'm confident this is only a bug existing in our e2e suite (and not in the cert-manager codebase itself) - we've got issues logged for this, but thanks for reporting too! 😄

Show resolved Hide resolved README.md Outdated
hopefully the last formatting tweak for this one
Signed-off-by: Joe Heck <heckj@mac.com>

@munnerz munnerz added this to Needs review in v0.6 Nov 26, 2018

@munnerz

This comment has been minimized.

Member

munnerz commented Nov 26, 2018

🙏 thanks so much for this! 😄

/lgtm
/approve

@jetstack-bot

This comment has been minimized.

Collaborator

jetstack-bot commented Nov 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@munnerz munnerz moved this from Needs review to Reviewer approved in v0.6 Nov 26, 2018

@munnerz

This comment has been minimized.

Member

munnerz commented Nov 26, 2018

/retest

@jetstack-bot jetstack-bot merged commit bbd459f into jetstack:master Nov 26, 2018

11 checks passed

dco All commits have Signed-off-by
Details
pull-cert-manager-bazel Job succeeded.
Details
pull-cert-manager-chart Job succeeded.
Details
pull-cert-manager-codegen Skipped
pull-cert-manager-deps Job succeeded.
Details
pull-cert-manager-docs Skipped
pull-cert-manager-e2e-v1-11 Job succeeded.
Details
pull-cert-manager-e2e-v1-12 Job succeeded.
Details
pull-cert-manager-lint Skipped
pull-cert-manager-unit Skipped
tide In merge pool.
Details

v0.6 automation moved this from Reviewer approved to Done Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment