Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acme.cert-manager.io API group and move Orders & Challenges #2093

Merged
merged 13 commits into from Sep 23, 2019
Merged

Add acme.cert-manager.io API group and move Orders & Challenges #2093

merged 13 commits into from Sep 23, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Sep 20, 2019

What this PR does / why we need it:

Adds a dedicated API group to home ACME types. There is currently a dependency from the core 'certmanager' API onto the 'acme' API due to the Issuer resource containing configuration for all different types of issuer.

This will likely remain through 1.0, unless we decide to remove the Issuer/ClusterIssuer resource types in favour of dedicated ACMEIssuer types, etc.

Which issue this PR fixes: fixes #2073

Special notes for your reviewer:

This depends on #2090

Release note:

ACTION REQUIRED: Move Order and Challenge resources to the acme.cert-manager.io API group

/hold

@jetstack-bot jetstack-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code labels Sep 20, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ca Indicates a PR directly modifies the CA Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing area/vault Indicates a PR directly modifies the Vault Issuer code kind/documentation Categorizes issue or PR as related to documentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 20, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 20, 2019
@munnerz
Copy link
Member Author

munnerz commented Sep 21, 2019

/retest

@JoshVanL
Copy link
Collaborator

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@munnerz
Move acme API types into acme group
e42a603 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Add internal acme API group
5608751 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update test/ packages for new ACME group
406e977 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update update-codegen
9fcb66d 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update generated clientsets and informers
00456a6 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update pkg/controllers
2868b4a 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update pkg/issuer
73460c1 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update reference docs generation
9d64392 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Add ACME apigroup to scheme
68cf0c0 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update CRD manifests
71ccc0e 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update RBAC rules
d8d7d8f 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Use acmefuzzers during certmanager group roundtrip tests
ac123be 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update vendor
60636b2 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@munnerz
Copy link
Member Author

munnerz commented Sep 23, 2019

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2019
@JoshVanL
Copy link
Collaborator

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@JoshVanL
Copy link
Collaborator

/retest

@jetstack-bot jetstack-bot merged commit b8bd8dc into cert-manager:master Sep 23, 2019
@jetstack-bot jetstack-bot added this to the v0.11 milestone Sep 23, 2019
@munnerz munnerz added this to Done in v0.11 Sep 27, 2019
@jetstack-bot jetstack-bot mentioned this pull request Oct 21, 2019
Closed
@dungdm93 dungdm93 mentioned this pull request Oct 15, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

@vdesjardins vdesjardins Awaiting requested review from vdesjardins

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/ca Indicates a PR directly modifies the CA Issuer code area/deploy Indicates a PR modifies deployment configuration area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing area/vault Indicates a PR directly modifies the Vault Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
v0.11
  
Done
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

Order & Challenge better naming
3 participants
@munnerz @jetstack-bot @JoshVanL