Adds an explicit timeout when pre-checking HTTP-01 challenges #4311
Conversation
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
jetstack-bot
added
release-note
|
/kind bug |
jetstack-bot
added
kind/bug
|
/cherry-pick release-1.3 |
|
@jakexks: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cert-manager-bazel flake |
|
/test pull-cert-manager-e2e-v1-21 |
|
/cherry-pick release-1.4 |
|
@JoshVanL: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.5 |
|
@JoshVanL: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| // boulder sets this to 1 because "0" means "unlimited" | ||
| MaxIdleConns: 1, | ||
|
|
||
| // IdleConnTimeout's value is taken from Boulder | ||
| IdleConnTimeout: time.Second, |
There was a problem hiding this comment.
q: do these values really matter if we are only using this client for 1 request?
There was a problem hiding this comment.
I pretty much just copied boulder. The link to their http.Transport just above here (https://github.com/letsencrypt/boulder/blob/30a516737c9daa4c88c8c47070c25a5e7033cdcf/va/http.go#L146-L160) has some detail on their side.
There was a problem hiding this comment.
(to anticipate the obvious follow-up question, we don't have TLSHandshakeTimeout because the http.Client Timeout covers that. Boulder has much subtler, fancier time-out handling but I think a blunt 10s timeout is better here for this PR given this will be backported and we don't want to go nuts with changes)
There was a problem hiding this comment.
Understood, but I don't think these Idle fields are actually doing anything.
|
/lgtm |
jetstack-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
jetstack-bot
removed
the
do-not-merge/hold
|
@jakexks: new pull request created: #4317 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoshVanL: new pull request created: #4318 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoshVanL: new pull request created: #4319 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As discussed in standup 2021-08-05.