Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] cmctl status was fetching v1beta1 orders instead of v1 #4572

Merged
merged 1 commit into from Oct 29, 2021
Merged

[release-1.6] cmctl status was fetching v1beta1 orders instead of v1 #4572

merged 1 commit into from Oct 29, 2021

Conversation

jetstack-bot
Copy link
Collaborator

This is an automated cherry-pick of #4569

/assign JoshVanL

Fixes an issue in `cmctl` that prevented displaying the Order resource with cert-manager
1.6 when running `cmctl status certificate`.

@maelvls
cmctl status was fetching v1beta1 orders instead of v1
486ca7c 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 29, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 29, 2021
Merged
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2021
@jakexks
Copy link
Member

jakexks commented Oct 29, 2021

/kind bug
/approve
/lgtm

@jetstack-bot jetstack-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2021
@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 29, 2021
@jetstack-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, jetstack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@jakexks jakexks added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 29, 2021
@jetstack-bot jetstack-bot merged commit 5ecf5b5 into cert-manager:release-1.6 Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakexks jakexks

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jetstack-bot @jakexks @JoshVanL @maelvls