Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes v1beta1 from webhook's admissionReviewVersions as we no longer support Kubernetes v1.16 #4639

Merged
merged 1 commit into from Dec 2, 2021
Merged

Removes v1beta1 from webhook's admissionReviewVersions as we no longer support Kubernetes v1.16 #4639

merged 1 commit into from Dec 2, 2021

Conversation

JoshVanL
Copy link
Collaborator

@JoshVanL JoshVanL commented Dec 2, 2021 •
edited by wallrj

Previously, cert-manager supported Kubernetes v1.16 which meant that cert-manager's webhook configuration needed to include v1beta1 as a admissionReviewVersions, even though it wasn't actually served. See: kubernetes/kubernetes#82025

Since we longer support Kubernetes v1.16, we can remove that version from the configuration.

Clean up: Remove `v1beta1` form the webhook's `admissionReviewVersions` as cert-manager no longer supports v1.16

/kind cleanup
/milestone v1.7

@JoshVanL
Removes v1beta1 from webhook's admissionReviewVersions as we no longer
6d83e31 
support Kubernetes v1.16

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot
Copy link
Collaborator

@JoshVanL: The provided milestone is not valid for this repository. Milestones in this repository: [1.6, Next, v1.5, v1.7]

Use /milestone clear to clear the milestone.

In response to this:

Previously, cert-manager supported Kubernetes v1.16 which meant that cert-manager's webhook configuration needed to include v1beta1 as a admissionReviewVersions, even though it wasn't actually served. See: kubernetes/kubernetes#82025

Since we longer support Kubernetes v1.16, we can remove that version from the configuration.

Clean up: Remove `v1beta1` form the webhook's admissionReviewVersions as cert-manager no longer supports v1.16

/kind cleanup
/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2021
@JoshVanL JoshVanL added this to the v1.7 milestone Dec 2, 2021
@JoshVanL
Copy link
Collaborator Author

JoshVanL commented Dec 2, 2021 

(10:47:46) WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Unknown host: mirror.bazel.build
(10:47:46) WARNING: Download from https://github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Unknown host: github-releases.githubusercontent.com
(10:47:46) ERROR: An error occurred during the fetch of repository 'io_bazel_rules_go':
   Traceback (most recent call last):
	File "/bazel-scratch/.cache/bazel/_bazel_root/e50ce42c8209d553b7e7491e69e67e89/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip, https://github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip] to /bazel-scratch/.cache/bazel/_bazel_root/e50ce42c8209d553b7e7491e69e67e89/external/io_bazel_rules_go/temp3908159889827578221/rules_go-v0.28.0.zip: Unknown host: github-releases.githubusercontent.com
(10:47:46) ERROR: Error fetching repository: Traceback (most recent call last):
	File "/bazel-scratch/.cache/bazel/_bazel_root/e50ce42c8209d553b7e7491e69e67e89/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip, https://github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip] to /bazel-scratch/.cache/bazel/_bazel_root/e50ce42c8209d553b7e7491e69e67e89/external/io_bazel_rules_go/temp3908159889827578221/rules_go-v0.28.0.zip: Unknown host: github-releases.githubusercontent.com
(10:47:46) ERROR: no such package '@io_bazel_rules_go//go': java.io.IOException: Error downloading [https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip, https://github.com/bazelbuild/rules_go/releases/download/v0.28.0/rules_go-v0.28.0.zip] to /bazel-scratch/.cache/bazel/_bazel_root/e50ce42c8209d553b7e7491e69e67e89/external/io_bazel_rules_go/temp3908159889827578221/rules_go-v0.28.0.zip: Unknown host: github-releases.githubusercontent.com

Spicy.

/retest

@irbekrm
Copy link
Collaborator

irbekrm commented Dec 2, 2021

Makes sense 👍🏼

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@jetstack-bot jetstack-bot merged commit 7923823 into cert-manager:master Dec 2, 2021
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @irbekrm