Adds an info log when test-all-containers is false #34
Conversation
fixes jetstack#31 Signed-off-by: Wiard van Rij <w.vanrij@fullstaq.com>
|
Hi @wiardvanrij. Thanks for your PR. I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @JoshVanL |
cmd/app/app.go
Outdated
| @@ -87,6 +87,10 @@ func NewCommand(ctx context.Context) *cobra.Command { | |||
| } | |||
| }() | |||
|
|
|||
| if !opts.DefaultTestAll { | |||
| log.Info("Argument test-all-containers is FALSE. Only containers with the annotation 'enable.version-checker.io' will be parsed") | |||
There was a problem hiding this comment.
nit: "flag --test-all-containers=%t so only containers with the annotation 'enable.version-checker.io' will be parsed"
There was a problem hiding this comment.
Nice. I've even enriched it a bit more. Let me know if that's too much..
There was a problem hiding this comment.
No that's great!
Can we also have the same only containers with the annotation "enable.version-checker.io/${my-container}=true" will be parsed for when the flag is false.
Also remove the brackets around opts.DefaultTestAll
Signed-off-by: Wiard van Rij <w.vanrij@fullstaq.com>
|
/unassign |
Signed-off-by: Wiard van Rij <w.vanrij@fullstaq.com>
|
Cheers @wiardvanrij ! /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, wiardvanrij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #31
Signed-off-by: Wiard van Rij w.vanrij@fullstaq.com