From 02f35deeaac1ed056e5c69aedbed73eef582e0d0 Mon Sep 17 00:00:00 2001 From: Joakim Erdfelt Date: Mon, 2 Nov 2020 11:07:21 -0600 Subject: [PATCH] Issue #5539 - Deprecating 'xml' request parameter in StatisticsServlet Signed-off-by: Joakim Erdfelt --- .../jetty/servlet/StatisticsServlet.java | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java b/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java index 3c6f325dd8b4..889f7f3b2f25 100644 --- a/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java +++ b/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java @@ -118,6 +118,11 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t return; } + if (request.getParameter("xml") != null) + { + LOG.warn("'xml' parameter is deprecated, use 'Accept' request header instead"); + } + List acceptable = getOrderedAcceptableMimeTypes(request); for (String mimeType : acceptable) @@ -134,21 +139,8 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t writeHtmlResponse(response); return; case "text/plain": - writeTextResponse(response); - return; case "*/*": - String wantXml = request.getParameter("xml"); - if (wantXml == null) - wantXml = request.getParameter("XML"); - - if (Boolean.parseBoolean(wantXml)) - { - writeXmlResponse(response); - } - else - { - writeTextResponse(response); - } + writeTextResponse(response); return; default: if (LOG.isDebugEnabled())