Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Feature Request: Allow for Indexing #3

Merged
merged 1 commit into from Jul 3, 2012

Conversation

Projects
None yet
3 participants
Contributor

maxdemarzi commented Jul 2, 2012

Allowing users to specify csv files for fulltext and exact indexing of nodes and relationships.

Owner

jexp commented Jul 3, 2012

max could you squash your commits into one? with git rebase -i ccd110e "p"ick the first one and "s"quash the others into a single commit.

updating libraries and adding Lucene dependency in order to
implement node and relationship indexing.
Contributor

maxdemarzi commented Jul 3, 2012

Done.

Owner

jexp commented Jul 3, 2012

Thanks,

What do you think about my suggestion of skipping these additional index files and rather using the header for this? Seems less involved?

Contributor

maxdemarzi commented Jul 3, 2012

I think doing it this way we capture the more general case and avoid problems with:

  • wanting a field to be indexed in two indexes
  • indexes that use values not included in the nodes (I could see this for aliases, or i18n)
  • easier to update the importer as you add a file without messing with your nodes.csv

jexp added a commit that referenced this pull request Jul 3, 2012

Merge pull request #3 from maxdemarzi/master
Feature Request: Allow for Indexing

@jexp jexp merged commit 69c442d into jexp:master Jul 3, 2012

Owner

jexp commented Jul 3, 2012

I think those are rather the 10% use cases so I'm still not convinced that they are worth the effort :)

I think I'll implement the other solution for the 90% case

Two side notes: always close writers/streams + do it in a finally clause and specify the encoding for the streams

Contributor

maxdemarzi commented Jul 5, 2012

I'm a Ruby guy, so I did what I could... >8-]

Sounds like somebody (cough Peter cough) is volunteering a pull-request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment