New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'DELETE' postprocessor documentation typo #354

Closed
feedingaliencat opened this Issue Aug 26, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@feedingaliencat

feedingaliencat commented Aug 26, 2014

I think there is something wrong in the DELETE postprocessor documentation:
It says:

def delete_postprocessor(was_deleted=None, **kw):

when is instead:

def delete_postprocessor(is_deleted=None, **kw):

@jfinkels jfinkels added bug labels Aug 26, 2014

@jfinkels

This comment has been minimized.

Owner

jfinkels commented Aug 26, 2014

You are right. The documentation is correct, and the code is incorrect; they should both read was_deleted (since by the time the postprocessor gets the information, the instance has already been deleted from the table). I will fix this right now.

This error was introduced in 3b74c6f, where we changed from positional arguments to keyword arguments in processors. I failed to update the name of the keyword argument in the code.

@jfinkels jfinkels closed this in decbb80 Aug 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment