Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE is either wrong in the code or in the docs #398

Closed
jwanglof opened this issue Feb 5, 2015 · 2 comments
Closed

DELETE is either wrong in the code or in the docs #398

jwanglof opened this issue Feb 5, 2015 · 2 comments
Labels

Comments

@jwanglof
Copy link

@jwanglof jwanglof commented Feb 5, 2015

In the latest docs (0.16.1-dev) it clearly states that:

Changed in version 0.16.0: Replaced DELETE with DELETE_MANY and DELETE_SINGLE.

However, when I insert a pre- or post-processor to DELETE_SINGLE nothing is happening, either before the request or after. When I looked in the tests for 0.16.0 (granted, this is not the latest but the docs says 0.16.0 and the latest official release is 0.16.0) it tests against DELETE and not DELETE_SINGLE

Line 217 in tests/test_processors.py:

pre = dict(DELETE=[check_permissions])

This should be changed to DELETE_SINGLE to correlate with the documents, or the document should change from DELETE_SINGLE to DELETE.

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Feb 6, 2015

Yes, this is a bug. That's my bad, sorry! I'll fix it right away.

Loading

@jfinkels jfinkels added the bug label Feb 6, 2015
jfinkels added a commit that referenced this issue Feb 6, 2015
The code handling HTTP DELETE requests had not been updated to handle
DELETE_SINGLE requests as described by the documentation (as introduced
in 5e84c00). Now the `delete()` method
in `views.py` correctly checks for DELETE_SINGLE preprocessors instead
of DELETE preprocessors.

Fixes issue #398.
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Feb 6, 2015

This is fixed by 79ea9a4.

Loading

@jfinkels jfinkels closed this Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants