Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dictionary type association proxies #247

Merged
merged 5 commits into from Mar 13, 2014
Merged

Add support for dictionary type association proxies #247

merged 5 commits into from Mar 13, 2014

Conversation

@Svenito
Copy link
Contributor

@Svenito Svenito commented Sep 23, 2013

Related to issue #244

Sven Steinbauer added 2 commits Sep 23, 2013
The issue is that AssociationDict type does not have an `append` method
@@ -1631,6 +1661,8 @@ class Product(self.Base):
tag_names = prox('tags', 'name',
creator=lambda tag_name: Tag(name=tag_name))


Copy link
Owner

@jfinkels jfinkels Dec 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove superfluous newlines.

Loading

@jfinkels jfinkels merged commit 07ebbc6 into jfinkels:master Mar 13, 2014
1 check passed
Loading
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Mar 13, 2014

Merged, thanks.

Loading

@Svenito Svenito deleted the assoc-proxy branch Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants