Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 on empty search result #249

Merged
merged 1 commit into from Mar 13, 2014
Merged

Return 404 on empty search result #249

merged 1 commit into from Mar 13, 2014

Conversation

@Svenito
Copy link
Contributor

@Svenito Svenito commented Sep 27, 2013

An empty result should return a 404 not a 400.

At least that's what I would expect. Offering this PR in case it's needed

An empty result should return a 404 not a 400
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Dec 1, 2013

This seems reasonable. Please fix the current conflicts and also change the corresponding example docs/searchformat.rst.

Loading

@Svenito
Copy link
Contributor Author

@Svenito Svenito commented Dec 2, 2013

By conflict do you mean the travis failure? I can't see a merge conflict.

Loading

@jfinkels jfinkels merged commit 04345ff into jfinkels:master Mar 13, 2014
1 check failed
Loading
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Mar 13, 2014

This has been merged. Thanks.

Loading

@Svenito Svenito deleted the empty-result-404 branch Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants