New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 on empty search result #249

Merged
merged 1 commit into from Mar 13, 2014

Conversation

Projects
None yet
2 participants
@Svenito
Contributor

Svenito commented Sep 27, 2013

An empty result should return a 404 not a 400.

At least that's what I would expect. Offering this PR in case it's needed

Sven Steinbauer
Return 404 on empty search result
An empty result should return a 404 not a 400
@jfinkels

This comment has been minimized.

Owner

jfinkels commented Dec 1, 2013

This seems reasonable. Please fix the current conflicts and also change the corresponding example docs/searchformat.rst.

@Svenito

This comment has been minimized.

Contributor

Svenito commented Dec 2, 2013

By conflict do you mean the travis failure? I can't see a merge conflict.

@jfinkels jfinkels merged commit 04345ff into jfinkels:master Mar 13, 2014

1 check failed

default The Travis CI build failed
Details
@jfinkels

This comment has been minimized.

Owner

jfinkels commented Mar 13, 2014

This has been merged. Thanks.

@Svenito Svenito deleted the Svenito:empty-result-404 branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment