Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a relation is null return a 404 instead of throwing exception #254

Closed
wants to merge 2 commits into from
Closed

If a relation is null return a 404 instead of throwing exception #254

wants to merge 2 commits into from

Conversation

@Svenito
Copy link
Contributor

@Svenito Svenito commented Oct 4, 2013

Due to the result being None an exception is thrown. It makes more sense to me to return a 404 in this case

Sven Steinbauer added 2 commits Oct 4, 2013
If a relation is null and is fetched with
/api/pets/2/user

an exception is raised raised rather than a 404 being returned
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Mar 13, 2014

I have merged this. Thanks.

Loading

@jfinkels jfinkels closed this Mar 13, 2014
@Svenito Svenito deleted the empty-rel-404 branch Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants