New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the order of postprocessor. #264

Merged
merged 1 commit into from Dec 1, 2013

Conversation

Projects
None yet
2 participants
@yoyicue

yoyicue commented Nov 22, 2013

Currently, I do not need primary_key in json, the original logic has some problems.

Original logic:
Executive postprocessor -> Assignment headers
Optimized logic:
Assignment headers -> Execute postprocessor

Like:
https://github.com/jfinkels/flask-restless/blob/master/flask_restless/views.py#L964

李达
@jfinkels

This comment has been minimized.

Owner

jfinkels commented Dec 1, 2013

I will merge this because both the _search() and post() methods should be consistent (that is, assigning headers and executing postprocessors should occur in the same order in both methods, whichever order that may be). However, I don't quite understand what problem this is solving. I also don't understand why you call this "optimized logic"; why is this more efficient? Please provide a test case.

jfinkels added a commit that referenced this pull request Dec 1, 2013

Merge pull request #264 from yoyicue/master
Modify the order of postprocessor.

@jfinkels jfinkels merged commit 19ae672 into jfinkels:master Dec 1, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment