Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds model.query documentation and allows model.query to be a callable #270
I am not opposed to this. However, you need better tests. Some of the tests you gave are testing implementation, not behavior. Some of the tests were redundant, that is, they were testing old functionality for which tests already exist as opposed to the newly introduced functionality. Finally, your main test does not take advantage of the callable query attribute in a meaningful way.
I have pushed a branch that has my changes to your pull request at master...callable_query_attribute. Before I pull this in, though, I would like to see a test that 1) modifies an existing model class like