New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count() when LIMIT is set #333

Merged
merged 1 commit into from Jul 15, 2014

Conversation

Projects
None yet
2 participants
@fluxism
Contributor

fluxism commented Jul 10, 2014

Using just a limit in search_params, the limit is not enforced. In helpers.count() num_results always contains the full count. This change forces the use of query.count() when a LIMIT is set.

jfinkels added a commit that referenced this pull request Jul 15, 2014

Merge pull request #333 from fluxism/fix-limit
Fix count() when LIMIT is set

@jfinkels jfinkels merged commit 691ab6b into jfinkels:master Jul 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment