Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow group_by arguments in search requests #353

Closed
wants to merge 1 commit into from

Conversation

@sauloal
Copy link
Contributor

@sauloal sauloal commented Aug 22, 2014

order_by parameter

order_by parameter
@jfinkels jfinkels changed the title order_by Allow group_by arguments in search requests Aug 22, 2014
@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Aug 22, 2014

I think you mean group_by instead of order_by (the latter already exists).

Loading

@@ -127,6 +127,21 @@ def __repr__(self):
return '<OrderBy {0}, {1}>'.format(self.field, self.direction)


class GroupBy(object):
"""Represents an "order by" in a SQL query expression."""
Copy link
Owner

@jfinkels jfinkels Aug 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change an "order by" to a "group by".

Loading

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Aug 22, 2014

This is good, but I won't merge this without tests or documentation. Also please attend to the comments I made on the diff.

Loading

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Feb 3, 2015

I fixed the problems with this pull request and merged it in commit 493637b.

Loading

@jfinkels jfinkels closed this Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants