Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 327: order by relation #391

Merged
merged 3 commits into from Jan 31, 2015

Conversation

@rcomblen
Copy link

@rcomblen rcomblen commented Jan 29, 2015

  • Solving issue #327
 - Solving issue jfinkels#327
@rcomblen rcomblen changed the title Fox for issue 327: order by relation Fix for issue 327: order by relation Jan 29, 2015

# When
d = {
'filters': [{'name': 'owner', 'op': 'has', 'val': {'name': 'name', 'op': 'like', 'val': '%y'}}],
Copy link
Owner

@jfinkels jfinkels Jan 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trim line to at most 79 characters.

Loading

@rcomblen
Copy link
Author

@rcomblen rcomblen commented Jan 30, 2015

Thanks for the feedback. If some kind of compliance is mandatory (e.g. pep8 or pylint), it might make sense to describe it in the README.md.

Loading

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Jan 31, 2015

I'll make a note in the README.

Loading

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Jan 31, 2015

This looks good, thank you!

Loading

jfinkels added a commit that referenced this issue Jan 31, 2015
@jfinkels jfinkels merged commit ae036c6 into jfinkels:master Jan 31, 2015
1 check passed
Loading
@rcomblen
Copy link
Author

@rcomblen rcomblen commented Feb 2, 2015

When is this going to be in an official release ?

Loading

@jfinkels
Copy link
Owner

@jfinkels jfinkels commented Feb 2, 2015

I'd like to pull in another change before releasing this as version 0.16.0.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants