New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 327: order by relation #391

Merged
merged 3 commits into from Jan 31, 2015

Conversation

Projects
None yet
2 participants
@rcomblen

rcomblen commented Jan 29, 2015

  • Solving issue #327
Richard Comblen
Order by relation
 - Solving issue #327

@rcomblen rcomblen changed the title from Fox for issue 327: order by relation to Fix for issue 327: order by relation Jan 29, 2015

# When
d = {
'filters': [{'name': 'owner', 'op': 'has', 'val': {'name': 'name', 'op': 'like', 'val': '%y'}}],

This comment has been minimized.

@jfinkels

jfinkels Jan 29, 2015

Owner

Trim line to at most 79 characters.

assert results[1].owner.name == u'Lucy'

This comment has been minimized.

@jfinkels

jfinkels Jan 29, 2015

Owner

One too many newlines here.

@@ -90,6 +90,104 @@ def test_query_related_field(self):
assert results[1].other == 19

This comment has been minimized.

@jfinkels

jfinkels Jan 29, 2015

Owner

Remove this blank line; there should be only one between methods.

Richard Comblen added some commits Jan 30, 2015

@rcomblen

This comment has been minimized.

rcomblen commented Jan 30, 2015

Thanks for the feedback. If some kind of compliance is mandatory (e.g. pep8 or pylint), it might make sense to describe it in the README.md.

@jfinkels

This comment has been minimized.

Owner

jfinkels commented Jan 31, 2015

I'll make a note in the README.

@jfinkels

This comment has been minimized.

Owner

jfinkels commented Jan 31, 2015

This looks good, thank you!

jfinkels added a commit that referenced this pull request Jan 31, 2015

Merge pull request #391 from rcomblen/feature/order_by_relation
Fix for issue 327: order by relation

@jfinkels jfinkels merged commit ae036c6 into jfinkels:master Jan 31, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rcomblen

This comment has been minimized.

rcomblen commented Feb 2, 2015

When is this going to be in an official release ?

@jfinkels

This comment has been minimized.

Owner

jfinkels commented Feb 2, 2015

I'd like to pull in another change before releasing this as version 0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment