Permalink
Commits on May 16, 2010
  1. Change on Array extension from rand => random_element [#4555 state:co…

    spastorino authored and fxn committed May 16, 2010
    …mmitted]
    
    Signed-off-by: Xavier Noria <fxn@hashref.com>
  2. Significantly improved internal encoding heuristics and support.

    wycats committed May 16, 2010
    * Default Encoding.default_internal to UTF-8
    * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file
    * Read templates as BINARY, use default_external or template-wide magic comments
      inside the Template to set the initial encoding
      * This means that template handlers in Ruby 1.9 will receive Strings encoded
        in default_internal (UTF-8 by default)
    * Create a better Exception for encoding issues, and use it when the template
      source has bytes that are not compatible with the specified encoding
    * Allow template handlers to opt-into handling BINARY. If they do so, they
      need to do some of their own manual encoding work
    * Added a "Configuration Gotchas" section to the intro Rails Guide instructing
      users to use UTF-8 for everything
    * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid
      $KCODE value is used
    
    Also:
    * Fixed a few tests that were assert() rather than assert_equal() and
      were caught by Minitest requiring a String for the message
    * Fixed a test where an assert_select was misformed, also caught by
      Minitest being more restrictive
    * Fixed a test where a Rack response was returning a String rather
      than an Enumerable
  3. Added nokogiri dependency to Gemfile [#4617 state:resolved]

    priit authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  4. prevent to run fixture accessor (e.g. test_foos for TestFoo model) as…

    no6v authored and josevalim committed May 16, 2010
    … a test case [#2992 state:resolved]
    
    Signed-off-by: Wijnand Wiersma <wijnand@videre.net>
    Signed-off-by: José Valim <jose.valim@gmail.com>
  5. Gemfile requires sqlite3-ruby = 1.3.0.beta.2

    spastorino authored and fxn committed May 16, 2010
    Signed-off-by: Xavier Noria <fxn@hashref.com>
  6. Tests for new reserved words [#4602 state:resolved]

    simonjefford authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  7. Added rails command aliases (s g c db) to reserved words in app gener…

    kossnocorp authored and josevalim committed May 16, 2010
    …ator [#4602 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  8. I have updated the documentation according to ticket #4263 about fixt…

    franckverrot authored and josevalim committed Apr 8, 2010
    …ures and set_fixture_class
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  9. Take out stale tasks from Actionpack's Rakefile [#4619 state:resolved]

    rizwanreza authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  10. Takes out stale methods relating to edge_rails_version

    rizwanreza authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  11. Added missing require, we are using bind method defined on active_sup…

    spastorino authored and josevalim committed May 16, 2010
    …port/core_ext/proc
    
    [#4610 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  12. Make use of assert_equal to test equallity between object assert expe…

    spastorino authored and josevalim committed May 16, 2010
    …cts and object and a message of error
    
    [#4611 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  13. Postgresql doesn't allow to change a string type column to a binary t…

    Wijnand authored and josevalim committed May 16, 2010
    …ype. Skip this test for postgresql for now. [#4616 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  14. Check blocks are not incorrectly detected when compiling erubis templ…

    simonjefford authored and josevalim committed May 16, 2010
    …ates [#4575 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  15. Fixed 1 failure in ActionPack testsuite [#4613 state:resolved]

    HusseinMorsy authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  16. added support for html attributes in options_for_select [#2165]

    pleax authored and josevalim committed May 15, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  17. Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:com…

    rohit authored and josevalim committed May 16, 2010
    …mited]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  18. Fix Hash#index deprecated warning in 1.9.x [#4600 state:resolved]

    kossnocorp authored and josevalim committed May 15, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  19. Added assert_attribute_type to clean up GeneratedAttributeTest [#2377

    jeffkreeftmeijer authored and josevalim committed May 16, 2010
    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  20. using :time_select when the attribute type is :time in the scaffold g…

    jeffkreeftmeijer authored and josevalim committed May 14, 2010
    …enerator. [#2377 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  21. Fixed two failing tests in railties on 1.9.2-head [#4609 state:commited]

    rohit authored and josevalim committed May 16, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  22. Don't carry default value when changing column for a binary type on M…

    Elomar França authored and josevalim committed Sep 27, 2009
    …ySQL [#3234 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on May 15, 2010
  1. Expose remaining hooks to minimize the need for a Railtie based on fe…

    josevalim committed May 15, 2010
    …edback from plugin developers.
  2. Ensure that eager_load actually takes place just after the middleware…

    josevalim committed May 15, 2010
    … stack is built by using another pattern.
    
    Also create a engine_blank_point initializer to ensure any :before or :after hooks defined inside engines won't move the configuration initializers to other places.
  3. Sending :id => nil to form helpers now properly omits the "id" html e…

    zilkey authored and josevalim committed May 15, 2010
    …lement [#4559 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  4. Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accep…

    josevalim committed May 15, 2010
    …t an options hash and make various Validators pass their (filtered) options."
    
    Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object.
    
    This reverts commit bc1c8d5.
  5. make sure `as` is set before trying to build an #{as}_counter. [#2804

    jeffkreeftmeijer authored and jeremy committed May 15, 2010
    …state:resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  6. Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an opt…

    jeroenvandijk authored and jeremy committed May 15, 2010
    …ions hash and make various Validators pass their (filtered) options.
    
    This makes it possible to pass additional options through Validators to message
    generation. E.g. plugin authors want to add validates_presence_of :foo, :format
    => "some format".
    
    Also, cleanup the :default vs :message options confusion in ActiveModel
    validation message generation.
    
    Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in
    favor of ActiveModel::Errors#add_on_blank(attributes, options).
    
    Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again
    
    [#4057 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  7. Reset quoted_table_name after set_table_name [#4568 state:resolved]

    spastorino authored and lifo committed May 15, 2010
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>