John Firebaugh
jfirebaugh

Organizations

@openstreetmap @rubinius @mapbox @ruby-debug @chaijs @Leaflet @osmlab @maptime @Turfjs @Project-OSRM @documentationjs @DADACONF
Jul 23, 2016
Jul 22, 2016
@jfirebaugh
  • @jfirebaugh 3a8f0dc
    [core] Don't allow style mutations to be overwritten by revalidation
Jul 22, 2016
@jfirebaugh
Jul 22, 2016
@jfirebaugh

What are your thoughts on combining setPaintProperty and setLayoutProperty into a single setProperty method, so as to leave the difference unexpose…

Jul 22, 2016
@jfirebaugh
  • @GretaCB 4b1eead
    [node] Fix integer conversion of filter values
jfirebaugh deleted branch explicit-conversion at mapbox/mapbox-gl-native
Jul 22, 2016
Jul 22, 2016
@jfirebaugh
Explicit conversion
4 commits with 3 additions and 3 deletions
Jul 22, 2016
@jfirebaugh
  • @GretaCB fbd511a
    add testcase for explicit int type v8 conversion (#127)
Jul 22, 2016
@jfirebaugh
Add testcase for explicit int type v8 conversion
1 commit with 55 additions and 0 deletions
Jul 22, 2016
jfirebaugh commented on pull request mapbox/mapbox-gl-test-suite#127
@jfirebaugh

👌

Jul 22, 2016
jfirebaugh commented on pull request mapbox/mapbox-gl-native#5727
@jfirebaugh

In addition to being constant values, style properties can be functions. In core, this is expressed via the PropertyValue template, which can repre…

Jul 22, 2016
@jfirebaugh
  • @jfirebaugh b074c99
    [core] Don't allow style mutations to be overwritten by revalidation
  • @jfirebaugh 2f7d8fc
    [tests] Merge single test in set_style.cpp with other Map tests
  • 3 more commits »
Jul 22, 2016
@jfirebaugh
Jul 22, 2016
@jfirebaugh
[core] Don't allow style mutations to be overwritten by revalidation
2 commits with 165 additions and 34 deletions
Jul 21, 2016
@jfirebaugh

Probably #4117.

Jul 21, 2016
jfirebaugh commented on pull request mapbox/mapbox-gl-native#5744
@jfirebaugh

I wonder if 2 is enough for the PushLocalFrame parameter. It's not clear to me exactly what a safe value is. I assume that things like std_string_t…

Jul 20, 2016
@jfirebaugh

Great diagnosis @ivovandongen -- I didn't think about nesting, but that's definitely the problem. The danger in reposting change events on the even…

Jul 19, 2016
jfirebaugh commented on pull request mapbox/mapbox-gl-js#2897
@jfirebaugh

:+1

jfirebaugh deleted branch 5631-Empty-Marker-Crash at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch tmpsantos-node_bench at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch geometry-0.8.0 at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-v3.2.2 at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-v3.2.1 at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch 5186-sessionid at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-raster-pool-patch at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-v3.2.0 at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-v3.1.3 at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch node-texture-leak at mapbox/mapbox-gl-native
Jul 19, 2016
jfirebaugh deleted branch 5004-mapboxaccountmanager at mapbox/mapbox-gl-native
Jul 19, 2016