New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input/Output file encoding setting [sf#29] #164

Closed
lsf37 opened this Issue Feb 15, 2015 · 2 comments

Comments

1 participant
@lsf37
Member

lsf37 commented Feb 15, 2015

*Reported by anonymous on 2013-04-15 04:54 UTC
It seems that current implementation only accepts system default encoding settings for input (.flex) / output (.java) file.

I think both command line argument and ANT script settings should have encoding options.

Suggested command line example:

java JFlex.Main -encoding utf-8 CodeTest.flex

Suggested ANT script entry example:

<jflex file="${src.dir}/CodeTest.flex" destdir="${build.generated.sources.dir}/flex" encoding="utf-8" />

@lsf37 lsf37 changed the title from Input/Output file encoding setting to [Feature] Input/Output file encoding setting [sf#29] Feb 15, 2015

@lsf37 lsf37 added this to the jflex milestone Feb 15, 2015

@lsf37 lsf37 added the enhancement label Feb 15, 2015

@lsf37 lsf37 removed this from the jflex milestone Feb 15, 2015

@lsf37 lsf37 added this to the release 1.7.0 milestone Mar 23, 2015

@regisd regisd changed the title from [Feature] Input/Output file encoding setting [sf#29] to Input/Output file encoding setting [sf#29] Aug 29, 2018

regisd added a commit that referenced this issue Sep 3, 2018

Use UTF-8 encoding in example projects (#301)
Fixes [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!

See also #164

@regisd regisd added this to TODO in JFlex core Sep 10, 2018

@lsf37 lsf37 self-assigned this Sep 15, 2018

@lsf37 lsf37 moved this from Open feature requests to In progress in JFlex core Sep 15, 2018

@lsf37 lsf37 referenced this issue Sep 16, 2018

Merged

Encoding #308

@lsf37 lsf37 closed this Sep 16, 2018

JFlex core automation moved this from In progress to Done Sep 16, 2018

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Sep 18, 2018

Member

Addressing review comments

Member

lsf37 commented Sep 18, 2018

Addressing review comments

@lsf37 lsf37 reopened this Sep 18, 2018

JFlex core automation moved this from Done to In progress Sep 18, 2018

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Sep 21, 2018

Member

Now also does output file encoding in adcbeee

Member

lsf37 commented Sep 21, 2018

Now also does output file encoding in adcbeee

@lsf37 lsf37 closed this Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment