New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cup 0.11b #175

Closed
regisd opened this Issue Mar 5, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@regisd
Member

regisd commented Mar 5, 2015

CUP has released version 0.11b

  • CUP version 0.11b 20140808 is a feature/bugfix release.
    • added expected symbols to the report_error(...) method
    • added an expected_token_ids() to inform about valid continuations
    • added parameters and code to enable automatic creation of XML parse trees
    • fixed a bug in the lookahead computation
  • CUP version 0.11b beta 20140226 is a feature release.
    • Command line flag -locations now triggers the generation of the identifiers
    • xleft and xright in the actions section instead of left and right.
    • Both are of type ComplexSymbolFactory.Location instead of plain ints.
  • CUP version 0.11b beta 20140220 is a feature release.
    • Main switch statement now splits the action code in bundles of 300 productions
      on several different method bodies. Should fix the 65k size boundary problem
@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Mar 5, 2015

Member

Should we use it for the 1.6.1 release or leave the update for after that?

Member

lsf37 commented Mar 5, 2015

Should we use it for the 1.6.1 release or leave the update for after that?

@tbl0605

This comment has been minimized.

Show comment
Hide comment
@tbl0605

tbl0605 Mar 5, 2015

For me, latest dev version of JFlex 1.6.1 seems rock solid and corrects a long standing bug (#135) blocking us migrating from version 1.4.3, and should be released asap ;) So why introduce now potentially new problems by changing the cup version ? Of course, it's only my opinion! :)

Btw, there's even a newer cup version (0.11b 20150226) available on http://www2.cs.tum.edu/projects/cup/, but without any changelog.

tbl0605 commented Mar 5, 2015

For me, latest dev version of JFlex 1.6.1 seems rock solid and corrects a long standing bug (#135) blocking us migrating from version 1.4.3, and should be released asap ;) So why introduce now potentially new problems by changing the cup version ? Of course, it's only my opinion! :)

Btw, there's even a newer cup version (0.11b 20150226) available on http://www2.cs.tum.edu/projects/cup/, but without any changelog.

@lsf37 lsf37 added the task label Mar 5, 2015

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Mar 6, 2015

Member

I'm tending to leave it for the next release as well. Any objections?

Member

lsf37 commented Mar 6, 2015

I'm tending to leave it for the next release as well. Any objections?

@regisd

This comment has been minimized.

Show comment
Hide comment
@regisd

regisd Mar 6, 2015

Member

I agree.

Le jeu. 5 mars 2015 17:27, Gerwin Klein notifications@github.com a écrit :

I'm tending to leave it for the next release as well. Any objections?


Reply to this email directly or view it on GitHub
#175 (comment).

Member

regisd commented Mar 6, 2015

I agree.

Le jeu. 5 mars 2015 17:27, Gerwin Klein notifications@github.com a écrit :

I'm tending to leave it for the next release as well. Any objections?


Reply to this email directly or view it on GitHub
#175 (comment).

@lsf37 lsf37 closed this in d945e5b Mar 21, 2015

lsf37 added a commit that referenced this issue Mar 21, 2015

cup update continued
added everything I accidentally left out of the last commit..

(see also #175)

@lsf37 lsf37 added this to the release 1.7.0 milestone Mar 23, 2015

@tbl0605

This comment has been minimized.

Show comment
Hide comment
@tbl0605

tbl0605 Mar 28, 2015

Hello,
I recently discovered that version 11b-20150226 had a nasty bug (introduced somewhere after v10k) that was corrected in latest 11b-20150326 version. In the changelog of cup it's described as :
"Fixed an issue with empty productions having non-empty location information".
It's about wrong position calculation of empty productions.

I was the original reporter of this bug to the maintainer of CUP.
I don't know if it impacts JFlex, but nevertheless, I still strongly advice you to make an additional update (to 11b-20150326), only a few files changed ;)

tbl0605 commented Mar 28, 2015

Hello,
I recently discovered that version 11b-20150226 had a nasty bug (introduced somewhere after v10k) that was corrected in latest 11b-20150326 version. In the changelog of cup it's described as :
"Fixed an issue with empty productions having non-empty location information".
It's about wrong position calculation of empty productions.

I was the original reporter of this bug to the maintainer of CUP.
I don't know if it impacts JFlex, but nevertheless, I still strongly advice you to make an additional update (to 11b-20150326), only a few files changed ;)

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Mar 28, 2015

Member

Thanks for reporting that. We should be on the latest even version of cup, but will double check.

Member

lsf37 commented Mar 28, 2015

Thanks for reporting that. We should be on the latest even version of cup, but will double check.

@lsf37 lsf37 reopened this Mar 28, 2015

regisd added a commit to regisd/jflex that referenced this issue Apr 7, 2015

Bump JDK to version 6.
Cup 11b now requires JDK 6 to compile.
Since we now use cub 11b (see jflex-de#175), bump our prerequesite from Jdk 5 to jdk 6.
@regisd

This comment has been minimized.

Show comment
Hide comment
@regisd

regisd Apr 1, 2017

Member

Done in d945e5b

Member

regisd commented Apr 1, 2017

Done in d945e5b

@regisd regisd closed this Apr 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment