Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to cup 0.11b #175

Closed
regisd opened this issue Mar 5, 2015 · 7 comments
Closed

Upgrade to cup 0.11b #175

regisd opened this issue Mar 5, 2015 · 7 comments
Labels
task Process tasks
Milestone
1.7.0

Comments

@regisd
Copy link
Member

regisd commented Mar 5, 2015

CUP has released version 0.11b

  • CUP version 0.11b 20140808 is a feature/bugfix release.
    • added expected symbols to the report_error(...) method
    • added an expected_token_ids() to inform about valid continuations
    • added parameters and code to enable automatic creation of XML parse trees
    • fixed a bug in the lookahead computation
  • CUP version 0.11b beta 20140226 is a feature release.
    • Command line flag -locations now triggers the generation of the identifiers
    • xleft and xright in the actions section instead of left and right.
    • Both are of type ComplexSymbolFactory.Location instead of plain ints.
  • CUP version 0.11b beta 20140220 is a feature release.
    • Main switch statement now splits the action code in bundles of 300 productions
      on several different method bodies. Should fix the 65k size boundary problem
@lsf37
Copy link
Member

lsf37 commented Mar 5, 2015

Should we use it for the 1.6.1 release or leave the update for after that?

@tbl0605
Copy link

tbl0605 commented Mar 5, 2015

For me, latest dev version of JFlex 1.6.1 seems rock solid and corrects a long standing bug (#135) blocking us migrating from version 1.4.3, and should be released asap ;) So why introduce now potentially new problems by changing the cup version ? Of course, it's only my opinion! :)

Btw, there's even a newer cup version (0.11b 20150226) available on http://www2.cs.tum.edu/projects/cup/, but without any changelog.

@lsf37 lsf37 added the task Process tasks label Mar 5, 2015
@lsf37
Copy link
Member

lsf37 commented Mar 6, 2015

I'm tending to leave it for the next release as well. Any objections?

@regisd
Copy link
Member Author

regisd commented Mar 6, 2015

I agree.

Le jeu. 5 mars 2015 17:27, Gerwin Klein notifications@github.com a écrit :

I'm tending to leave it for the next release as well. Any objections?

—
Reply to this email directly or view it on GitHub
#175 (comment).

@lsf37 lsf37 closed this as completed in d945e5b Mar 21, 2015
lsf37 added a commit that referenced this issue Mar 21, 2015
@lsf37
cup update continued
13691c7 
added everything I accidentally left out of the last commit..

(see also #175)
@lsf37 lsf37 added this to the release 1.7.0 milestone Mar 23, 2015
@tbl0605
Copy link

tbl0605 commented Mar 28, 2015

Hello,
I recently discovered that version 11b-20150226 had a nasty bug (introduced somewhere after v10k) that was corrected in latest 11b-20150326 version. In the changelog of cup it's described as :
"Fixed an issue with empty productions having non-empty location information".
It's about wrong position calculation of empty productions.

I was the original reporter of this bug to the maintainer of CUP.
I don't know if it impacts JFlex, but nevertheless, I still strongly advice you to make an additional update (to 11b-20150326), only a few files changed ;)

@lsf37
Copy link
Member

lsf37 commented Mar 28, 2015

Thanks for reporting that. We should be on the latest even version of cup, but will double check.

@lsf37 lsf37 reopened this Mar 28, 2015
regisd added a commit to regisd/jflex that referenced this issue Apr 7, 2015
@regisd
Bump JDK to version 6.
3a810a8 
Cup 11b now requires JDK 6 to compile.
Since we now use cub 11b (see jflex-de#175), bump our prerequesite from Jdk 5 to jdk 6.
@regisd regisd mentioned this issue Apr 7, 2015
Merged
@regisd
Copy link
Member Author

regisd commented Apr 1, 2017

Done in d945e5b

@regisd regisd closed this as completed Apr 1, 2017
regisd added a commit to regisd/jflex that referenced this issue Oct 19, 2018
@regisd
Upgrade cup-11b to java-cup-bin-11b-20160615
a8ea1dc 
Upgrade from 11b-20150226 (see commit d945e5b jflex-de#175)
to 11b-20160615

binary release from http://www2.cs.tum.edu/projects/cup/
Sources from https://versioncontrolseidl.in.tum.de/parsergenerators/cup.git (assuming master at that date, i.e. commit fe729fe8c27441f046dab19135a38b9dde4c4e5e)
No changes in runtime.

Changelog:

UP version 0.11b 20151001 is a feature release.

Implemented a generic pre-/post DFS search with visitor support
Also added fragments of XPath 1.0 query support on parse trees
Fixed the visibility of children and the variant attribute of XMLElement

------------------------------------------------------------------------
CUP version 0.11b 20150326 is a bugfix release.

Fixed an issue with empty productions having non-empty location information
Fixed an issue with deprecation of constructors
@regisd regisd mentioned this issue Oct 19, 2018
Merged
regisd added a commit that referenced this issue Dec 2, 2019
@regisd
Upgrade cup-11b to java-cup-bin-11b-20160615 (#477)
7a3d66f 
* Upgrade cup-11b to java-cup-bin-11b-20160615

Upgrade from 11b-20150226 (see commit d945e5b #175)
to 11b-20160615

binary release from http://www2.cs.tum.edu/projects/cup/
Sources from https://versioncontrolseidl.in.tum.de/parsergenerators/cup.git (assuming master at that date, i.e. commit fe729fe8c27441f046dab19135a38b9dde4c4e5e)
No changes in runtime.

Changelog:

UP version 0.11b 20151001 is a feature release.

Implemented a generic pre-/post DFS search with visitor support
Also added fragments of XPath 1.0 query support on parse trees
Fixed the visibility of children and the variant attribute of XMLElement


CUP version 0.11b 20150326 is a bugfix release.

Fixed an issue with empty productions having non-empty location information
Fixed an issue with deprecation of constructors

* Update java_cup.runtime with java-cup-src-11b-20160615

http://www2.cs.tum.edu/projects/cup/releases/java-cup-src-11b-20160615.tar.gz

* Cup source now requires Java 7

/home/travis/build/jflex-de/jflex/cup/cup_runtime/src/main/java/java_cup/runtime/SyntaxTreeTransform.java:[17,79] diamond operator is not supported in -source 6
  (use -source 7 or higher to enable diamond operator)

* Rename 11b to 11b-20160615

* Update version of cup in bazel via jflex-de/bazel_rules#18

* Remove unused cup.bzl
  Follow-up of #466

* build+README adjustments in examples for cup-0.11b-20160615
regisd pushed a commit that referenced this issue Dec 2, 2019
@traviscibot
Pseudo-Merge 7a3d66f Upgrade cup-11b to java-cup-bin-11b-20160615 (#477)
6127b3b 
commit 7a3d66f
Author:     Régis Décamps <regisd@google.com>
AuthorDate: Mon Dec 2 23:45:11 2019 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Mon Dec 2 23:45:11 2019 +0100

    Upgrade cup-11b to java-cup-bin-11b-20160615 (#477)

    * Upgrade cup-11b to java-cup-bin-11b-20160615

    Upgrade from 11b-20150226 (see commit d945e5b #175)
    to 11b-20160615

    binary release from http://www2.cs.tum.edu/projects/cup/
    Sources from https://versioncontrolseidl.in.tum.de/parsergenerators/cup.git (assuming master at that date, i.e. commit fe729fe8c27441f046dab19135a38b9dde4c4e5e)
    No changes in runtime.

    Changelog:

    UP version 0.11b 20151001 is a feature release.

    Implemented a generic pre-/post DFS search with visitor support
    Also added fragments of XPath 1.0 query support on parse trees
    Fixed the visibility of children and the variant attribute of XMLElement

    CUP version 0.11b 20150326 is a bugfix release.

    Fixed an issue with empty productions having non-empty location information
    Fixed an issue with deprecation of constructors

    * Update java_cup.runtime with java-cup-src-11b-20160615

    http://www2.cs.tum.edu/projects/cup/releases/java-cup-src-11b-20160615.tar.gz

    * Cup source now requires Java 7

    /home/travis/build/jflex-de/jflex/cup/cup_runtime/src/main/java/java_cup/runtime/SyntaxTreeTransform.java:[17,79] diamond operator is not supported in -source 6
      (use -source 7 or higher to enable diamond operator)

    * Rename 11b to 11b-20160615

    * Update version of cup in bazel via jflex-de/bazel_rules#18

    * Remove unused cup.bzl
      Follow-up of #466

    * build+README adjustments in examples for cup-0.11b-20160615

Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Process tasks
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
3 participants
@regisd @tbl0605 @lsf37