Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print char position in debug mode if char directive is present #207

Closed
ghost opened this issue Nov 5, 2016 · 4 comments
Closed

Print char position in debug mode if char directive is present #207

ghost opened this issue Nov 5, 2016 · 4 comments
Assignees
Labels
Projects
Milestone

Comments

@ghost
Copy link

@ghost ghost commented Nov 5, 2016

Equally to the behaviour of %column and %line when %debug is active could %char also force to print he value of yychar in the debug messages.

@lsf37
Copy link
Member

@lsf37 lsf37 commented Apr 10, 2017

That would make sense. Will need to look into if there is any problem with that, sounds like something we should have implemented a long time ago.

@lsf37 lsf37 added the enhancement label Apr 10, 2017
@lsf37 lsf37 added this to the release 1.7.0 milestone Apr 10, 2017
@regisd regisd added this to Open feature requests in JFlex core Sep 10, 2018
lsf37 added a commit that referenced this issue Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for
each match. As opposed to yyline and yycolumn counting who report yyline+1 and
yycolumn+1, the yychar reporting starts at 0, because it is more likely to be
useful as an index into a buffer (whereas line and column are more likely to
be useful in an editor).

Fixes issue #207.
lsf37 added a commit that referenced this issue Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for
each match. As opposed to yyline and yycolumn counting who report yyline+1 and
yycolumn+1, the yychar reporting starts at 0, because it is more likely to be
useful as an index into a buffer (whereas line and column are more likely to
be useful in an editor).

Fixes issue #207.
lsf37 added a commit that referenced this issue Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for
each match. As opposed to yyline and yycolumn counting who report yyline+1 and
yycolumn+1, the yychar reporting starts at 0, because it is more likely to be
useful as an index into a buffer (whereas line and column are more likely to
be useful in an editor).

Fixes issue #207.
@lsf37
Copy link
Member

@lsf37 lsf37 commented Sep 16, 2018

This is now implemented in 2b17a9b

@lsf37 lsf37 closed this Sep 16, 2018
JFlex core automation moved this from Open feature requests to Done Sep 16, 2018
@lsf37
Copy link
Member

@lsf37 lsf37 commented Sep 18, 2018

Review comments still to address.

@lsf37 lsf37 reopened this Sep 18, 2018
JFlex core automation moved this from Done to In progress Sep 18, 2018
@lsf37
Copy link
Member

@lsf37 lsf37 commented Sep 20, 2018

Review feedback addressed in 85ec33e

@lsf37 lsf37 closed this Sep 20, 2018
JFlex core automation moved this from In progress to Done Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
JFlex core
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.