-
Notifications
You must be signed in to change notification settings - Fork 117
Print char position in debug mode if char directive is present #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That would make sense. Will need to look into if there is any problem with that, sounds like something we should have implemented a long time ago. |
lsf37
added a commit
that referenced
this issue
Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for each match. As opposed to yyline and yycolumn counting who report yyline+1 and yycolumn+1, the yychar reporting starts at 0, because it is more likely to be useful as an index into a buffer (whereas line and column are more likely to be useful in an editor). Fixes issue #207.
lsf37
added a commit
that referenced
this issue
Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for each match. As opposed to yyline and yycolumn counting who report yyline+1 and yycolumn+1, the yychar reporting starts at 0, because it is more likely to be useful as an index into a buffer (whereas line and column are more likely to be useful in an editor). Fixes issue #207.
lsf37
added a commit
that referenced
this issue
Sep 16, 2018
The main method of %debug scanners will now report the value of yychar for each match. As opposed to yyline and yycolumn counting who report yyline+1 and yycolumn+1, the yychar reporting starts at 0, because it is more likely to be useful as an index into a buffer (whereas line and column are more likely to be useful in an editor). Fixes issue #207.
This is now implemented in 2b17a9b |
Review comments still to address. |
Review feedback addressed in 85ec33e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Equally to the behaviour of
%column
and%line
when%debug
is active could%char
also force to print he value ofyychar
in the debug messages.The text was updated successfully, but these errors were encountered: