New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Need to defend against blanks in path to jflex bash script [sf#83] #85

Closed
lsf37 opened this Issue Feb 15, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@lsf37
Member

lsf37 commented Feb 15, 2015

*Reported by anonymous on 2007-01-07 14:44 UTC
The bash script distributed with jflex contains the following line inside the loop that turns a symbolic link to the script into a real path:

[ ${newprg} = ${newprg#/} ] && newprg=${PRG%/*}/${newprg}

If the path to jflex contains a blank, then this line fails with the error message "too many arguments".

What's needed (I believe) is to change this line to

[ "${newprg}" = "${newprg#/}" ] && newprg=${PRG%/*}/${newprg}

A small thing, but it worried me enough to spend the time to track it down to be sure something significant wasn't going on, so I expect it's worth fixing.

-- jcbeatty@uwaterloo.ca

@lsf37 lsf37 changed the title from Need to defend against blanks in path to jflex bash script to [Bug] Need to defend against blanks in path to jflex bash script [sf#83] Feb 15, 2015

@lsf37 lsf37 closed this Feb 15, 2015

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Commented by lsf37 on 2007-05-30 22:26 UTC
Logged In: YES
user_id=93534
Originator: NO

You're right. Thanks for the fix, I'll include it in the next version.

Gerwin

Member

lsf37 commented Feb 15, 2015

Commented by lsf37 on 2007-05-30 22:26 UTC
Logged In: YES
user_id=93534
Originator: NO

You're right. Thanks for the fix, I'll include it in the next version.

Gerwin

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Commented by lsf37 on 2007-11-03 05:41 UTC
Logged In: YES
user_id=93534
Originator: NO

Fixed in svn revision 258.

Member

lsf37 commented Feb 15, 2015

Commented by lsf37 on 2007-11-03 05:41 UTC
Logged In: YES
user_id=93534
Originator: NO

Fixed in svn revision 258.

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Updated by lsf37 on 2007-11-03 05:41 UTC

  • priority: 5 --> 3
  • status: open --> open-fixed
Member

lsf37 commented Feb 15, 2015

Updated by lsf37 on 2007-11-03 05:41 UTC

  • priority: 5 --> 3
  • status: open --> open-fixed
@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Commented by lsf37 on 2008-05-24 04:01 UTC
Logged In: YES
user_id=93534
Originator: NO

Just cleaning up: this is fixed in revision r258.

Member

lsf37 commented Feb 15, 2015

Commented by lsf37 on 2008-05-24 04:01 UTC
Logged In: YES
user_id=93534
Originator: NO

Just cleaning up: this is fixed in revision r258.

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Updated by lsf37 on 2008-05-27 11:46 UTC

  • status: open-fixed --> closed
Member

lsf37 commented Feb 15, 2015

Updated by lsf37 on 2008-05-27 11:46 UTC

  • status: open-fixed --> closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment