Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Unicode 10.0 #540

Merged
merged 4 commits into from Jan 25, 2019
Merged

Add support for Unicode 10.0 #540

merged 4 commits into from Jan 25, 2019

Conversation

sarowe
Copy link
Contributor

@sarowe sarowe commented Jan 16, 2019

No description provided.

@sarowe sarowe requested a review from lsf37 as a code owner Jan 16, 2019
public class UnicodeProperties {

/** Constant {@code UNICODE_VERSIONS="1.1, 1.1.5, 2, 2.0, 2.0.14, 2.1, 2.1.9,"{trunked}} */
Copy link
Contributor Author

@sarowe sarowe Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regisd : how are these javadoc comments generated? I don't know how to put them back.

@sarowe sarowe added the enhancement label Jan 16, 2019
@sarowe sarowe added this to the 1.8.0 milestone Jan 16, 2019
@sarowe
Copy link
Contributor Author

sarowe commented Jan 16, 2019

TODO: Add examples/tests for Unicode segmentation rules (UAX#29 & UAX#14) under testsuite cases unicode-{grapheme,sentence,word,line}-break/, like for 8.0: UnicodeGraphemeBreakRules_8_0, UnicodeSentenceBreakRules_8_0, UnicodeWordBreakRules_8_0, UnicodeLineBreakAlgorithm_8_0.

Note that I had done this for all Unicode versions from 5.2->8.0, but didn't get to it for 9.0, so I plan on adding 9.0's along with 10.0's under this PR.

sarowe added 2 commits Jan 16, 2019
…uster, and Word Break rules; also remove executable attribute from files that don't need it.
@sarowe
Copy link
Contributor Author

sarowe commented Jan 17, 2019

This is ready to go.

I've included it in the 1.8 milestone, though, since I don't think adding Unicode version support belongs in a patch release, so I'm going to hold off merging until we've either released or decided to skip 1.7.1.

@sarowe sarowe modified the milestones: 1.8.0, 1.7.1 Jan 17, 2019
lsf37
lsf37 approved these changes Jan 25, 2019
Copy link
Member

@lsf37 lsf37 left a comment

This looks fine from my side. It'd be nicer to not remove the generated comments, but I presume we can put them back in when we figure out how to.

@sarowe sarowe merged commit 70e076b into master Jan 25, 2019
4 of 5 checks passed
@sarowe sarowe deleted the Add_Unicode-10.0 branch Jan 25, 2019
regisd pushed a commit that referenced this issue Jan 25, 2019
Author: Steve Rowe <sarowe@apache.org>
Date:   Fri Jan 25 12:10:11 2019 -0500

    Add support for Unicode 10.0 (#540)

    * Add support for Unicode 10.0

    * Add example/test Unicode 9.0 & 10.0 grammars for Line, Sentence, Grapheme Cluster, and Word Break rules

Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
@regisd regisd added this to In progress in Unicode via automation Feb 13, 2019
@sarowe sarowe moved this from In progress to Done in Unicode Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
Unicode
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants