Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalise char class order before NFA construction #650

Merged
merged 1 commit into from Dec 4, 2019
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Dec 4, 2019

This is to make generated automata more easily comparable, in particular to make
them more obviously equal when they are isomorphic up to input renaming.

Will hopefully make the upcoming char class refactoring more robust to test.

@lsf37 lsf37 requested a review from sarowe as a code owner Dec 4, 2019
@lsf37 lsf37 self-assigned this Dec 4, 2019
@lsf37 lsf37 added the code quality label Dec 4, 2019
@lsf37 lsf37 added this to the 1.8.0 milestone Dec 4, 2019
This is to make generated automata more easily comparable, in particular to make
them more obviously equal when they are isomorphic up to input renaming.
@lsf37
Copy link
Member Author

lsf37 commented Dec 4, 2019

Codacy doesn't like the explicit NullPointerException, but the contract for compareTo requires a NullPointerException when the argument is null, so I'll leave that in.

@lsf37 lsf37 merged commit 5ca8fdb into master Dec 4, 2019
4 of 5 checks passed
@lsf37 lsf37 deleted the ccl-norm branch Dec 4, 2019
@lgtm-com
Copy link

lgtm-com bot commented Dec 4, 2019

This pull request introduces 1 alert when merging 2c2c0bd into 170197a - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant